Skip to content

Commit ca93d13

Browse files
committed
One source for trace file path
Closes BrentOzarULTD#854
1 parent 3df104d commit ca93d13

File tree

1 file changed

+4
-11
lines changed

1 file changed

+4
-11
lines changed

sp_Blitz.sql

Lines changed: 4 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -506,13 +506,6 @@ AS
506506
INSERT INTO #IgnorableWaits VALUES ('XE_DISPATCHER_WAIT');
507507
INSERT INTO #IgnorableWaits VALUES ('XE_LIVE_TARGET_TVF');
508508
INSERT INTO #IgnorableWaits VALUES ('XE_TIMER_EVENT');
509-
510-
511-
/* Used for the default trace checks. */
512-
DECLARE @TracePath NVARCHAR(256);
513-
SELECT @TracePath=CAST(value as NVARCHAR(256))
514-
FROM sys.fn_trace_getinfo(1)
515-
WHERE traceid=1 AND property=2;
516509

517510
SELECT @MsSinceWaitsCleared = DATEDIFF(MINUTE, create_date, CURRENT_TIMESTAMP) * 60000.0
518511
FROM sys.databases
@@ -3061,7 +3054,7 @@ AS
30613054
IF NOT EXISTS ( SELECT 1
30623055
FROM #SkipChecks
30633056
WHERE DatabaseName IS NULL AND CheckID = 150 )
3064-
AND @TracePath IS NOT NULL
3057+
AND @base_tracefilename IS NOT NULL
30653058
BEGIN
30663059

30673060
INSERT INTO #BlitzResults
@@ -3080,7 +3073,7 @@ AS
30803073
'Errors Logged Recently in the Default Trace' AS Finding ,
30813074
'https://BrentOzar.com/go/defaulttrace' AS URL ,
30823075
CAST(t.TextData AS NVARCHAR(4000)) AS Details
3083-
FROM sys.fn_trace_gettable(@TracePath, DEFAULT) t
3076+
FROM sys.fn_trace_gettable(@base_tracefilename, DEFAULT) t
30843077
WHERE t.EventClass = 22
30853078
AND t.Severity >= 17
30863079
AND t.StartTime > DATEADD(dd, -30, GETDATE())
@@ -3091,7 +3084,7 @@ AS
30913084
IF NOT EXISTS ( SELECT 1
30923085
FROM #SkipChecks
30933086
WHERE DatabaseName IS NULL AND CheckID = 151 )
3094-
AND @TracePath IS NOT NULL
3087+
AND @base_tracefilename IS NOT NULL
30953088
BEGIN
30963089
INSERT INTO #BlitzResults
30973090
( CheckID ,
@@ -3109,7 +3102,7 @@ AS
31093102
'File Growths Slow' AS Finding ,
31103103
'https://BrentOzar.com/go/filegrowth' AS URL ,
31113104
CAST(COUNT(*) AS NVARCHAR(100)) + ' growths took more than 15 seconds each. Consider setting file autogrowth to a smaller increment.' AS Details
3112-
FROM sys.fn_trace_gettable(@TracePath, DEFAULT) t
3105+
FROM sys.fn_trace_gettable(@base_tracefilename, DEFAULT) t
31133106
WHERE t.EventClass IN (92, 93)
31143107
AND t.StartTime > DATEADD(dd, -30, GETDATE())
31153108
AND t.Duration > 15000000

0 commit comments

Comments
 (0)