Skip to content

Commit abee43a

Browse files
committed
Increase column lengths
Apparently some people pass in really big parameters!
1 parent c5e1594 commit abee43a

File tree

2 files changed

+36
-36
lines changed

2 files changed

+36
-36
lines changed

sp_BlitzCache.sql

Lines changed: 22 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -1136,20 +1136,6 @@ CREATE TABLE #configuration (
11361136
value DECIMAL(38,0)
11371137
);
11381138

1139-
CREATE TABLE #stored_proc_info
1140-
(
1141-
SPID INT,
1142-
SqlHandle VARBINARY(64),
1143-
QueryHash BINARY(8),
1144-
variable_name NVARCHAR(128),
1145-
variable_datatype NVARCHAR(128),
1146-
converted_column_name NVARCHAR(128),
1147-
compile_time_value NVARCHAR(128),
1148-
proc_name NVARCHAR(300),
1149-
column_name NVARCHAR(128),
1150-
converted_to NVARCHAR(128)
1151-
);
1152-
11531139
CREATE TABLE #plan_creation
11541140
(
11551141
percent_24 DECIMAL(5, 2),
@@ -1200,14 +1186,28 @@ CREATE TABLE #trace_flags
12001186
session_trace_flags VARCHAR(1000)
12011187
);
12021188

1189+
CREATE TABLE #stored_proc_info
1190+
(
1191+
SPID INT,
1192+
SqlHandle VARBINARY(64),
1193+
QueryHash BINARY(8),
1194+
variable_name NVARCHAR(256),
1195+
variable_datatype NVARCHAR(256),
1196+
converted_column_name NVARCHAR(256),
1197+
compile_time_value NVARCHAR(4000),
1198+
proc_name NVARCHAR(1000),
1199+
column_name NVARCHAR(256),
1200+
converted_to NVARCHAR(256)
1201+
);
1202+
12031203
CREATE TABLE #variable_info
12041204
(
12051205
SPID INT,
12061206
QueryHash BINARY(8),
12071207
SqlHandle VARBINARY(64),
1208-
proc_name NVARCHAR(128),
1209-
variable_name NVARCHAR(200),
1210-
variable_datatype NVARCHAR(128),
1208+
proc_name NVARCHAR(1000),
1209+
variable_name NVARCHAR(256),
1210+
variable_datatype NVARCHAR(256),
12111211
compile_time_value NVARCHAR(4000)
12121212
);
12131213

@@ -1216,7 +1216,7 @@ CREATE TABLE #conversion_info
12161216
SPID INT,
12171217
QueryHash BINARY(8),
12181218
SqlHandle VARBINARY(64),
1219-
proc_name NVARCHAR(128),
1219+
proc_name NVARCHAR(256),
12201220
expression NVARCHAR(4000),
12211221
at_charindex AS CHARINDEX('@', expression),
12221222
bracket_charindex AS CHARINDEX(']', expression, CHARINDEX('@', expression)) - CHARINDEX('@', expression),
@@ -3098,9 +3098,9 @@ SELECT DISTINCT @@SPID,
30983098
CASE WHEN b.QueryType = 'Statement' THEN b.QueryType
30993099
ELSE SUBSTRING(b.QueryType, CHARINDEX('[', b.QueryType), LEN(b.QueryType) - CHARINDEX('[', b.QueryType))
31003100
END AS proc_name,
3101-
q.n.value('@Column', 'NVARCHAR(128)') AS variable_name,
3102-
q.n.value('@ParameterDataType', 'NVARCHAR(128)') AS variable_datatype,
3103-
q.n.value('@ParameterCompiledValue', 'NVARCHAR(1000)') AS compile_time_value
3101+
q.n.value('@Column', 'NVARCHAR(256)') AS variable_name,
3102+
q.n.value('@ParameterDataType', 'NVARCHAR(256)') AS variable_datatype,
3103+
q.n.value('@ParameterCompiledValue', 'NVARCHAR(4000)') AS compile_time_value
31043104
FROM #query_plan AS qp
31053105
JOIN ##bou_BlitzCacheProcs AS b
31063106
ON (b.QueryType = 'adhoc' AND b.QueryHash = qp.QueryHash)
@@ -3118,7 +3118,7 @@ SELECT DISTINCT @@SPID,
31183118
CASE WHEN b.QueryType = 'Statement' THEN b.QueryType
31193119
ELSE SUBSTRING(b.QueryType, CHARINDEX('[', b.QueryType), LEN(b.QueryType) - CHARINDEX('[', b.QueryType))
31203120
END AS proc_name,
3121-
qq.c.value('@Expression', 'NVARCHAR(128)') AS expression
3121+
qq.c.value('@Expression', 'NVARCHAR(4000)') AS expression
31223122
FROM #query_plan AS qp
31233123
JOIN ##bou_BlitzCacheProcs AS b
31243124
ON (b.QueryType = 'adhoc' AND b.QueryHash = qp.QueryHash)

sp_BlitzQueryStore.sql

Lines changed: 14 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -772,13 +772,13 @@ CREATE TABLE #stored_proc_info
772772
(
773773
sql_handle VARBINARY(64),
774774
query_hash BINARY(8),
775-
variable_name NVARCHAR(128),
776-
variable_datatype NVARCHAR(128),
777-
converted_column_name NVARCHAR(128),
778-
compile_time_value NVARCHAR(128),
779-
proc_name NVARCHAR(300),
780-
column_name NVARCHAR(128),
781-
converted_to NVARCHAR(128)
775+
variable_name NVARCHAR(256),
776+
variable_datatype NVARCHAR(256),
777+
converted_column_name NVARCHAR(256),
778+
compile_time_value NVARCHAR(4000),
779+
proc_name NVARCHAR(1000),
780+
column_name NVARCHAR(256),
781+
converted_to NVARCHAR(256)
782782
INDEX tf_ix_ids CLUSTERED (sql_handle, query_hash)
783783
);
784784

@@ -788,9 +788,9 @@ CREATE TABLE #variable_info
788788
(
789789
query_hash BINARY(8),
790790
sql_handle VARBINARY(64),
791-
proc_name NVARCHAR(128),
792-
variable_name NVARCHAR(200),
793-
variable_datatype NVARCHAR(128),
791+
proc_name NVARCHAR(1000),
792+
variable_name NVARCHAR(256),
793+
variable_datatype NVARCHAR(256),
794794
compile_time_value NVARCHAR(4000),
795795
INDEX vif_ix_ids CLUSTERED (sql_handle, query_hash)
796796
);
@@ -2963,9 +2963,9 @@ IF EXISTS ( SELECT 1
29632963
qp.query_hash,
29642964
qp.sql_handle,
29652965
b.proc_or_function_name AS proc_name,
2966-
q.n.value('@Column', 'NVARCHAR(128)') AS variable_name,
2967-
q.n.value('@ParameterDataType', 'NVARCHAR(128)') AS variable_datatype,
2968-
q.n.value('@ParameterCompiledValue', 'NVARCHAR(1000)') AS compile_time_value
2966+
q.n.value('@Column', 'NVARCHAR(256)') AS variable_name,
2967+
q.n.value('@ParameterDataType', 'NVARCHAR(256)') AS variable_datatype,
2968+
q.n.value('@ParameterCompiledValue', 'NVARCHAR(4000)') AS compile_time_value
29692969
FROM #query_plan AS qp
29702970
JOIN #working_warnings AS b
29712971
ON (b.query_hash = qp.query_hash AND b.proc_or_function_name = 'adhoc')
@@ -2980,7 +2980,7 @@ IF EXISTS ( SELECT 1
29802980
qp.query_hash,
29812981
qp.sql_handle,
29822982
b.proc_or_function_name AS proc_name,
2983-
qq.c.value('@Expression', 'NVARCHAR(128)') AS expression
2983+
qq.c.value('@Expression', 'NVARCHAR(4000)') AS expression
29842984
FROM #query_plan AS qp
29852985
JOIN #working_warnings AS b
29862986
ON (b.query_hash = qp.query_hash AND b.proc_or_function_name = 'adhoc')

0 commit comments

Comments
 (0)