Merged
Conversation
Owner
I'd just test a few random, weird ones, but doing all of them isn't necessary IMO.
If you'd like. I think that functionality is pretty standard, iirc. |
Collaborator
Author
|
@Qix- |
Qix-
approved these changes
Feb 11, 2025
Owner
|
Looks good, merge when ready :) |
Owner
|
Published as |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #256
Closes #258
Changes
color-convert@3color-string@2@Qix- I didn't list all converter use cases in
index.test-d.ts. Please let me know if you want to them all.And some tests are missing, like
.toJSON(). Should I fix them in this PR?