Improve Error Handling in Module Importer (#18)

Author: NFUChen

py_spring_core/__init__.py

@@ -22,7 +22,7 @@
 from py_spring_core.event.application_event_publisher import ApplicationEventPublisher
 from py_spring_core.event.commons import ApplicationEvent
 
-__version__ = "0.0.22"
+__version__ = "0.0.23"
 
 __all__ = [
     "PySpringApplication",

py_spring_core/commons/module_importer.py

@@ -59,7 +59,7 @@ def import_module_from_path(self, file_path: str) -> Optional[Any]:
             return module
         except Exception as error:
             logger.warning(f"[MODULE IMPORT] Failed to import {module_name}: {error}")
-            return None
+            raise error
 
     def extract_classes_from_module(self, module: Any) -> list[Type[object]]:
         """
@@ -84,16 +84,14 @@ def extract_classes_from_module(self, module: Any) -> list[Type[object]]:
     def import_classes_from_paths(
         self, 
         file_paths: Iterable[str], 
-        target_subclasses: Iterable[Type[object]] = [],
-        ignore_errors: bool = True
+        target_subclasses: Iterable[Type[object]] = []
     ) -> set[Type[object]]:
         """
         Import classes from multiple file paths with optional filtering.
         
         Args:
             file_paths (Iterable[str]): The file paths of the modules to import.
             target_subclasses (Iterable[Type[object]], optional): Target subclasses to filter. Defaults to [].
-            ignore_errors (bool, optional): Whether to ignore import errors. Defaults to True.
             
         Returns:
             set[Type[object]]: Set of imported classes.
@@ -103,9 +101,7 @@ def import_classes_from_paths(
         for file_path in file_paths:
             module = self.import_module_from_path(file_path)
             if module is None:
-                if not ignore_errors:
-                    raise ImportError(f"Failed to import module from {file_path}")
-                continue
+                raise ImportError(f"Failed to import module from {file_path}")
 
             loaded_classes = self.extract_classes_from_module(module)
             all_loaded_classes.extend(loaded_classes)

py_spring_core/core/utils.py

@@ -12,7 +12,6 @@
 
 def dynamically_import_modules(
     module_paths: Iterable[str],
-    is_ignore_error: bool = True,
     target_subclasses: Iterable[Type[object]] = [],
 ) -> set[Type[object]]:
     """
@@ -29,7 +28,6 @@ def dynamically_import_modules(
     return _module_importer.import_classes_from_paths(
         file_paths=module_paths,
         target_subclasses=target_subclasses,
-        ignore_errors=is_ignore_error
     )
 
 

tests/test_module_importer.py

@@ -204,24 +204,24 @@ class TestClass:
 
     def test_import_nonexistent_file(self):
         """Test importing a non-existent file."""
-        result = self.importer.import_module_from_path("/nonexistent/file.py")
-        assert result is None
+        with pytest.raises(FileNotFoundError):
+            self.importer.import_module_from_path("/nonexistent/file.py")
 
     def test_import_invalid_python_file(self):
         """Test importing a file with invalid Python syntax."""
         with tempfile.NamedTemporaryFile(mode='w', suffix='.py', delete=False) as f:
             f.write("""
 class TestClass:
     def __init__(self):
-        # Invalid syntax
+        # Invalid syntax - missing colon
         if True
             pass
 """)
             temp_file_path = f.name
 
         try:
-            result = self.importer.import_module_from_path(temp_file_path)
-            assert result is None
+            with pytest.raises(SyntaxError):
+                self.importer.import_module_from_path(temp_file_path)
 
         finally:
             os.unlink(temp_file_path)