Skip to content

Commit f17a6aa

Browse files
Merge pull request #128 from MihaiCristianCondrea/codex/fix-code-issues-marked-as-fixme
Fix FIXME issues and use string placeholders
2 parents 53758a9 + 1d6930d commit f17a6aa

File tree

29 files changed

+34
-33
lines changed

29 files changed

+34
-33
lines changed

app/src/main/java/com/d4rk/androidtutorials/java/ui/screens/android/lessons/navigation/bottomnavigation/BottomNavigationActivity.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ protected void onCreate(Bundle savedInstanceState) {
2626
edgeToEdgeDelegate.applyEdgeToEdgeBottomBar(binding.container, binding.bottomNav);
2727

2828
binding.bottomNav.setOnItemSelectedListener(item -> {
29-
binding.textView.setText(getString(R.string.selected) + " " + item.getTitle()); // FIXME: Do not concatenate text displayed with `setText`. Use resource string with placeholders.
29+
binding.textView.setText(getString(R.string.selected, item.getTitle()));
3030
return true;
3131
});
3232

app/src/main/java/com/d4rk/androidtutorials/java/ui/screens/android/lessons/navigation/drawer/NavigationDrawerActivity.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ protected void onCreate(Bundle savedInstanceState) {
2727
edgeToEdgeDelegate.applyEdgeToEdge(binding.container);
2828

2929
binding.navigationView.setNavigationItemSelectedListener(item -> {
30-
binding.textView.setText(getString(R.string.selected) + " " + item.getTitle()); // FIXME: Do not concatenate text displayed with `setText`. Use resource string with placeholders.
30+
binding.textView.setText(getString(R.string.selected, item.getTitle()));
3131
binding.drawerLayout.closeDrawer(GravityCompat.START);
3232
return true;
3333
});

app/src/main/res/values-ar-rEG/strings.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -229,7 +229,7 @@
229229
<string name="default_tab">التبويب الافتراضي</string>
230230
<string name="bottom_navigation_bar_labels">عناوين شريط التنقل السفلي</string>
231231
<string name="labeled">معنون</string>
232-
<string name="selected">المحدد</string>
232+
<string name="selected">المحدد %1$s</string>
233233
<string name="unlabeled">غير معنون</string>
234234
<string name="navigation">التنقل</string>
235235
<string name="bottom_navigation">شريط التنقل السفلي</string>

app/src/main/res/values-bg-rBG/strings.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -255,7 +255,7 @@
255255
<string name="default_tab">Раздел по подразбиране</string>
256256
<string name="bottom_navigation_bar_labels">Етикети на долната навигационна лента</string>
257257
<string name="labeled">С етикети</string>
258-
<string name="selected">Избрани</string>
258+
<string name="selected">Избрани %1$s</string>
259259
<string name="unlabeled">Без етикети</string>
260260
<string name="navigation">Навигация</string>
261261
<string name="bottom_navigation">Долна навигация</string>

app/src/main/res/values-bn-rBD/strings.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -255,7 +255,7 @@
255255
<string name="default_tab">ডিফল্ট ট্যাব</string>
256256
<string name="bottom_navigation_bar_labels">নিচের নেভিগেশন বার লেবেল</string>
257257
<string name="labeled">লেবেলযুক্ত</string>
258-
<string name="selected">নির্বাচিত</string>
258+
<string name="selected">নির্বাচিত %1$s</string>
259259
<string name="unlabeled">লেবেলবিহীন</string>
260260
<string name="navigation">নেভিগেশন</string>
261261
<string name="bottom_navigation">নীচের নেভিগেশন</string>

app/src/main/res/values-de-rDE/strings.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -255,7 +255,7 @@
255255
<string name="default_tab">Standard-Tab</string>
256256
<string name="bottom_navigation_bar_labels">Beschriftungen der unteren Navigationsleiste</string>
257257
<string name="labeled">Beschriftet</string>
258-
<string name="selected">Ausgewählt</string>
258+
<string name="selected">Ausgewählt %1$s</string>
259259
<string name="unlabeled">Unbeschriftet</string>
260260
<string name="navigation">Navigation</string>
261261
<string name="bottom_navigation">Untere Navigation</string>

app/src/main/res/values-es-rGQ/strings.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -255,7 +255,7 @@
255255
<string name="default_tab">Pestaña predeterminada</string>
256256
<string name="bottom_navigation_bar_labels">Etiquetas de la barra de navegación inferior</string>
257257
<string name="labeled">Etiquetado</string>
258-
<string name="selected">Seleccionado</string>
258+
<string name="selected">Seleccionado %1$s</string>
259259
<string name="unlabeled">Sin etiquetar</string>
260260
<string name="navigation">Navegación</string>
261261
<string name="bottom_navigation">Navegación inferior</string>

app/src/main/res/values-es-rMX/strings.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -229,7 +229,7 @@
229229
<string name="default_tab">Pestaña predeterminada</string>
230230
<string name="bottom_navigation_bar_labels">Etiquetas de la barra de navegación inferior</string>
231231
<string name="labeled">Etiquetado</string>
232-
<string name="selected">Seleccionado</string>
232+
<string name="selected">Seleccionado %1$s</string>
233233
<string name="unlabeled">Sin etiquetar</string>
234234
<string name="navigation">Navegación</string>
235235
<string name="bottom_navigation">Navegación inferior</string>

app/src/main/res/values-fil-rPH/strings.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -229,7 +229,7 @@
229229
<string name="default_tab">Default na tab</string>
230230
<string name="bottom_navigation_bar_labels">Mga label ng bottom navigation bar</string>
231231
<string name="labeled">May label</string>
232-
<string name="selected">Napili</string>
232+
<string name="selected">Napili %1$s</string>
233233
<string name="unlabeled">Walang label</string>
234234
<string name="navigation">Nabigasyon</string>
235235
<string name="bottom_navigation">Nabigasyong nasa ibaba</string>

app/src/main/res/values-fr-rFR/strings.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -255,7 +255,7 @@
255255
<string name="default_tab">Onglet par défaut</string>
256256
<string name="bottom_navigation_bar_labels">Étiquettes de la barre de navigation inférieure</string>
257257
<string name="labeled">Étiqueté</string>
258-
<string name="selected">Sélectionné</string>
258+
<string name="selected">Sélectionné %1$s</string>
259259
<string name="unlabeled">Non étiqueté</string>
260260
<string name="navigation">Navigation</string>
261261
<string name="bottom_navigation">Navigation inférieure</string>

0 commit comments

Comments
 (0)