Skip to content

Commit 7f60743

Browse files
Merge pull request #87 from MihaiCristianCondrea/codex/remove-search-apps-from-home-fragment
Remove search from Home fragment
2 parents 11c74b7 + bd5040d commit 7f60743

File tree

3 files changed

+1
-37
lines changed

3 files changed

+1
-37
lines changed

app/src/main/java/com/d4rk/androidtutorials/java/ui/screens/home/HomeFragment.java

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@
77

88
import androidx.annotation.NonNull;
99
import androidx.annotation.Nullable;
10-
import androidx.appcompat.widget.SearchView;
1110
import androidx.fragment.app.Fragment;
1211
import androidx.lifecycle.ViewModelProvider;
1312

@@ -40,19 +39,6 @@ public void onViewCreated(@NonNull View view, @Nullable Bundle savedInstanceStat
4039
getString(com.d4rk.androidtutorials.java.R.string.announcement_title),
4140
getString(com.d4rk.androidtutorials.java.R.string.announcement_subtitle)
4241
);
43-
binding.searchView.setOnQueryTextListener(new SearchView.OnQueryTextListener() {
44-
@Override
45-
public boolean onQueryTextSubmit(String query) {
46-
homeViewModel.setSearchQuery(query);
47-
return true;
48-
}
49-
50-
@Override
51-
public boolean onQueryTextChange(String newText) {
52-
homeViewModel.setSearchQuery(newText);
53-
return true;
54-
}
55-
});
5642
LayoutInflater inflater = LayoutInflater.from(requireContext());
5743
homeViewModel.getUiState().observe(getViewLifecycleOwner(), state -> {
5844
binding.announcementTitle.setText(state.announcementTitle());

app/src/main/java/com/d4rk/androidtutorials/java/ui/screens/home/HomeViewModel.java

Lines changed: 1 addition & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,6 @@ public class HomeViewModel extends ViewModel {
2929
private final GetAppPlayStoreUrlUseCase getAppPlayStoreUrlUseCase;
3030

3131
private final MutableLiveData<HomeUiState> uiState = new MutableLiveData<>();
32-
private final MutableLiveData<String> searchQuery = new MutableLiveData<>("");
3332
private List<PromotedApp> allPromotedApps = new ArrayList<>();
3433

3534
@Inject
@@ -76,20 +75,8 @@ public void setAnnouncements(String title, String subtitle) {
7675
uiState.setValue(current);
7776
}
7877

79-
public void setSearchQuery(String query) {
80-
searchQuery.setValue(query);
81-
filterPromotedApps();
82-
}
83-
8478
private void filterPromotedApps() {
85-
String query = searchQuery.getValue();
86-
List<PromotedApp> filtered = new ArrayList<>();
87-
for (PromotedApp app : allPromotedApps) {
88-
if (query == null || query.isEmpty() ||
89-
app.name().toLowerCase().contains(query.toLowerCase())) {
90-
filtered.add(app);
91-
}
92-
}
79+
List<PromotedApp> filtered = new ArrayList<>(allPromotedApps);
9380
HomeUiState current = uiState.getValue();
9481
if (current == null) {
9582
current = new HomeUiState("", "", getDailyTipUseCase.invoke(), filtered);

app/src/main/res/layout/fragment_home.xml

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -168,15 +168,6 @@
168168
android:text="@string/other_apps_title"
169169
android:textAppearance="@style/TextAppearance.Material3.TitleMedium" />
170170

171-
<androidx.appcompat.widget.SearchView
172-
android:id="@+id/search_view"
173-
android:layout_width="match_parent"
174-
android:layout_height="wrap_content"
175-
android:layout_marginBottom="8dp"
176-
android:queryHint="@string/search_tutorials_hint"
177-
android:contentDescription="@string/search_tutorials_content_description"
178-
android:iconifiedByDefault="false" />
179-
180171
<HorizontalScrollView
181172
android:layout_width="match_parent"
182173
android:layout_height="wrap_content"

0 commit comments

Comments
 (0)