-
Notifications
You must be signed in to change notification settings - Fork 16
Permalink
Choose a base ref
{{ refName }}
default
Choose a head ref
{{ refName }}
default
Checking mergeability…
Don’t worry, you can still create the pull request.
Comparing changes
Choose two branches to see what’s changed or to start a new pull request.
If you need to, you can also or
learn more about diff comparisons.
Open a pull request
Create a new pull request by comparing changes across two branches. If you need to, you can also .
Learn more about diff comparisons here.
base repository: jackaudio/headers
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
...
head repository: LADI/jack-headers
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: jack2
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
- 9 commits
- 14 files changed
- 3 contributors
Commits on Aug 22, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 6ce9c00 - Browse repository at this point
Copy the full SHA 6ce9c00View commit details -
Use a consistent style for copyright headers
I chose the most common one here, although the indentation is a bit odd.
Configuration menu - View commit details
-
Copy full SHA for b601e3d - Browse repository at this point
Copy the full SHA b601e3dView commit details -
The previous style(s) used in most places here violates the C standard, and in practice can trigger -Wreserved-id-macro in clang for client code. So, switch to a conventional style that doesn't trigger warnings (and is supported by tools like clang-tidy).
Configuration menu - View commit details
-
Copy full SHA for fe0ab49 - Browse repository at this point
Copy the full SHA fe0ab49View commit details -
Fix invalid/unusual documentation comment syntax
Collectively, these trigger warnings in both Doxygen and clang (-Wdocumentation-unknown-command). Weirdly, @p in doxygen doesn't do anything but print in a fixed-width font anyway, so just use Markdown quotes to replace it which has the same effect (and reads nicer in the source). The use of @param like @p was invalid, so do the same to those.
Configuration menu - View commit details
-
Copy full SHA for 4371aab - Browse repository at this point
Copy the full SHA 4371aabView commit details -
Configuration menu - View commit details
-
Copy full SHA for d339468 - Browse repository at this point
Copy the full SHA d339468View commit details -
Avoid clash with "register" keyword
This fixes a Doxygen warning where a (seemingly) non-existent parameter was documented.
Configuration menu - View commit details
-
Copy full SHA for 9130d18 - Browse repository at this point
Copy the full SHA 9130d18View commit details
Commits on Sep 6, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 2b7a0b4 - Browse repository at this point
Copy the full SHA 2b7a0b4View commit details
Commits on Jun 2, 2023
-
Configuration menu - View commit details
-
Copy full SHA for c2a66df - Browse repository at this point
Copy the full SHA c2a66dfView commit details
Commits on May 29, 2025
-
*: don't include standard C headers inside of extern "C"
Including C headers inside of `extern "C"` breaks use from C++. Hoist the includes of standard C headers above the block so we don't try to mangle the stdlib. I initially tried to scope this with a targeted change but it's too hard to do correctly that way. This way, we avoid whack-a-mole. Firefox is working around this in their e21461b7b8b39cc31ba53c47d4f6f310c673ff2f commit. Bug: https://bugzilla.mozilla.org/1953080
Configuration menu - View commit details
-
Copy full SHA for 74e192d - Browse repository at this point
Copy the full SHA 74e192dView commit details
Loading
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff master...jack2