Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: jackaudio/headers
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: LADI/jack-headers
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: jack2
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 9 commits
  • 14 files changed
  • 3 contributors

Commits on Aug 22, 2022

  1. Delete trailing whitespace

    drobilla committed Aug 22, 2022
    Configuration menu
    Copy the full SHA
    6ce9c00 View commit details
    Browse the repository at this point in the history
  2. Use a consistent style for copyright headers

    I chose the most common one here, although the indentation is a bit odd.
    drobilla committed Aug 22, 2022
    Configuration menu
    Copy the full SHA
    b601e3d View commit details
    Browse the repository at this point in the history
  3. Clean up include guards

    The previous style(s) used in most places here violates the C standard, and in
    practice can trigger -Wreserved-id-macro in clang for client code.  So, switch
    to a conventional style that doesn't trigger warnings (and is supported by
    tools like clang-tidy).
    drobilla committed Aug 22, 2022
    Configuration menu
    Copy the full SHA
    fe0ab49 View commit details
    Browse the repository at this point in the history
  4. Fix invalid/unusual documentation comment syntax

    Collectively, these trigger warnings in both Doxygen and
    clang (-Wdocumentation-unknown-command).  Weirdly, @p in doxygen doesn't do
    anything but print in a fixed-width font anyway, so just use Markdown quotes to
    replace it which has the same effect (and reads nicer in the source).  The use
    of @param like @p was invalid, so do the same to those.
    drobilla committed Aug 22, 2022
    Configuration menu
    Copy the full SHA
    4371aab View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    d339468 View commit details
    Browse the repository at this point in the history
  6. Avoid clash with "register" keyword

    This fixes a Doxygen warning where a (seemingly) non-existent parameter was
    documented.
    drobilla committed Aug 22, 2022
    Configuration menu
    Copy the full SHA
    9130d18 View commit details
    Browse the repository at this point in the history

Commits on Sep 6, 2022

  1. LADI/jack2 variants

    nedko committed Sep 6, 2022
    Configuration menu
    Copy the full SHA
    2b7a0b4 View commit details
    Browse the repository at this point in the history

Commits on Jun 2, 2023

  1. Configuration menu
    Copy the full SHA
    c2a66df View commit details
    Browse the repository at this point in the history

Commits on May 29, 2025

  1. *: don't include standard C headers inside of extern "C"

    Including C headers inside of `extern "C"` breaks use from C++. Hoist
    the includes of standard C headers above the block so we don't try
    to mangle the stdlib.
    
    I initially tried to scope this with a targeted change but it's too
    hard to do correctly that way. This way, we avoid whack-a-mole.
    
    Firefox is working around this in their e21461b7b8b39cc31ba53c47d4f6f310c673ff2f
    commit.
    
    Bug: https://bugzilla.mozilla.org/1953080
    thesamesam authored and nedko committed May 29, 2025
    Configuration menu
    Copy the full SHA
    74e192d View commit details
    Browse the repository at this point in the history
Loading