Skip to content

My first official commit #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Conary36 wants to merge 2 commits into
base: master
Choose a base branch
from
Open

My first official commit #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f331f77
My first official commit
Sep 8, 2019
145363d
ADD FLEX STYLING TO NAV BAR
Sep 14, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
123 changes: 122 additions & 1 deletion great-idea-website/css/index.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,4 +63,125 @@ h1, h2, h3, h4, h5 {
margin-bottom: 15px;
}

/* Your code starts here! */
/* Your code starts here! */
body{
margin: 40px;
}
.navbar{
display: flex;
text-align: left;
padding-bottom: 60px;
}
.navbar p{
display: inline-block;
padding-left: 40px;
padding-right: 60px;
justify-content: space-evenly;
}
.logo{
display: inline-block;
float: top;
padding-left: 90px;

}
.content_1{

width: 100%;
}
.innovate{
display: inline-block;
float: left;
margin-top: 5%;
margin-right: -5%;
margin-left: 7%;
width: 50%;
text-align: center;
font-size: 65px;
}
.content_1_box{
display: inline-block;
padding-top: 10px;
margin-left: -12%;
float: left;
width: 50%;
text-align: center;
font-size: 70px;
}
#started{
padding-top: 10px;
padding-right: 50px;
padding-bottom: 10px;
padding-left: 50px;
background-color: whitesmoke;
}
p{
font-size: inherit;
}
.overview{
width: 100%;
margin: 1%;

}
#features{
display: inline-block;
min-height: 100px;
margin: 1%;
width: 47%;
/* margin-left: auto;
margin-right: auto;
*/
margin-bottom: 30px;
}
#about{
display: inline-block;
min-height: 100px;
margin: 1%;
width: 47%;
margin-left: auto;
margin-right: auto;
margin-bottom: 30px;

}
.center{
display: block;
width: 1500px;
height: 200px;
margin-bottom: 30px;
}
.middle-img{
position: relative;
max-width: 100%;
max-height: auto;

}
#services{
display: inline-block;
float:left;
width:33.33%;
height:250px;

}
#product{
display: inline-block;
float:left;
width:33.33%;
height:250px;

}
#vision{
float:left;
width:33.33%;
height:250px;
Copy link

@ghost ghost Sep 10, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So far everything looks good. I'll have to see how it turned out tomorrow. The only critique I have is a small one. Make sure your code is neat. Have everything lined up evenly and uniformed. Might seem like a petty thing to critique right now but once we start getting into LESS and even JSX you will see how important it is to have neat code.


}
address{
display: block;

}
#info{
line-height: 0.80em;
}
.copyright{
text-align: center;
}

112 changes: 68 additions & 44 deletions great-idea-website/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,50 +14,74 @@
<![endif]-->
</head>

<body>

Services
Product
Vision
Features
About
Contact

<img class="logo" src="img/logo.png" alt="Great Idea! Company logo.">
Innovation
On
Demand

Get Started

<img src="img/header-img.png" alt="Image of a code snippet.">

Features
Aliquam elementum magna eros, ac posuere elvit tempus et. Suspendisse vel tempus odio, in interdutm nisi. Suspendisse eu ornare nisl. Nullam convallis augue justo, at imperdiet metus scelerisque quis.


About
Aliquam elementum magna eros, ac posuere elvit tempus et. Suspendisse vel tempus odio, in interdutm nisi. Suspendisse eu ornare nisl. Nullam convallis augue justo, at imperdiet metus scelerisque quis.

<img class="middle-img" src="img/mid-page-accent.jpg" alt="Image of code snippets across the screen">

Services
Aliquam elementum magna eros, ac posuere elvit tempus et. Suspendisse vel tempus odio, in interdutm nisi. Suspendisse eu ornare nisl. Nullam convallis augue justo, at imperdiet metus scelerisque quis.


Product
Aliquam elementum magna eros, ac posuere elvit tempus et. Suspendisse vel tempus odio, in interdutm nisi. Suspendisse eu ornare nisl. Nullam convallis augue justo, at imperdiet metus scelerisque quis.

Vision
Aliquam elementum magna eros, ac posuere elvit tempus et. Suspendisse vel tempus odio, in interdutm nisi. Suspendisse eu ornare nisl. Nullam convallis augue justo, at imperdiet metus scelerisque quis.

Contact
123 Way 456 Street
Somewhere, USA
1 (888) 888-8888
sales@greatidea.io

Copyright Great Idea! 2018
<body>
<nav class="navbar">
<p>Services</p>
<p>Product</p>
<p>Vision</p>
<p>Features</p>
<p>About</p>
<p>Contact</p>
<img class="logo" src="img/logo.png" alt="Great Idea! Company logo.">
</nav>

<div class="content_1">
<section class="innovate">
<h1>Innovation</h1>
<h1>On</h1>
<h1>Demand</h1>
<button id="started">
<p>Get Started</p>
Copy link

@ghost ghost Sep 10, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To save code space, you don't need to put p tags here. You could just put button and it would still work.

</button>
</section>
<section class="content_1_box">
<img src="img/header-img.png" alt="Image of a code snippet.">
</section>
</div>

<section class="overview">
<div id="features">
<h2>Features</h2>
<p>Aliquam elementum magna eros, ac posuere elvit tempus et. Suspendisse vel tempus odio, in interdutm nisi. Suspendisse eu ornare nisl. Nullam convallis augue justo, at imperdiet metus scelerisque quis.</p>
</div>

<div id="about">
<h2>About</h2>
<p>Aliquam elementum magna eros, ac posuere elvit tempus et. Suspendisse vel tempus odio, in interdutm nisi. Suspendisse eu ornare nisl. Nullam convallis augue justo, at imperdiet metus scelerisque quis.</p>
</div>

<div>
<img class="middle-img center" src="img/mid-page-accent.jpg" alt="Image of code snippets across the screen">
</div>

<div id="services">
<h2>Services</h2>
<p>Aliquam elementum magna eros, ac posuere elvit tempus et. Suspendisse vel tempus odio, in interdutm nisi. Suspendisse eu ornare nisl. Nullam convallis augue justo, at imperdiet metus scelerisque quis.</p>
</div>

<div id="product">
<h2>Product</h2>
<p>Aliquam elementum magna eros, ac posuere elvit tempus et. Suspendisse vel tempus odio, in interdutm nisi. Suspendisse eu ornare nisl. Nullam convallis augue justo, at imperdiet metus scelerisque quis.</p>
</div>

<div id="vision">
<h2>Vision</h2>
<p>Aliquam elementum magna eros, ac posuere elvit tempus et. Suspendisse vel tempus odio, in interdutm nisi. Suspendisse eu ornare nisl. Nullam convallis augue justo, at imperdiet metus scelerisque quis.</p>
</div>

</section>

<address>
<h3>Contact</h3><br>
<div id="info">
<p>123 Way 456 Street</p>
<p>Somewhere, USA</p>
</div><br>
<p>1 (888) 888-8888<br></p>
<p>sales@greatidea.io</p>
</address>

<p class="copyright">Copyright Great Idea! 2018</p>

</body>
</html>