Conversation
| @@ -1,9 +0,0 @@ | |||
| .gitattributes | |||
There was a problem hiding this comment.
This package was never published to NPM.
| @@ -1,84 +0,0 @@ | |||
| /* | |||
There was a problem hiding this comment.
This was only referenced from scroll-wrapper, so has been deleted.
| @@ -1,71 +0,0 @@ | |||
| /* | |||
There was a problem hiding this comment.
This was only referenced from scroll-wrapper, so has been deleted.
There was a problem hiding this comment.
Is the plan just to fix these tests after? https://search.d2l.dev/xref/lms/uiautomation-tests/D2L.Automation.UI.PageObjects/Dropbox/DropboxFoldersListPage.cs?r=58509bd2#274
| @@ -1,39 +0,0 @@ | |||
| /* | |||
There was a problem hiding this comment.
This was once referenced from the LMS, but that usage has been removed so deleting this file.
| d2l-table[type="light"] d2l-td, | ||
| d2l-table[type="light"] d2l-th { | ||
| border-top: var(--d2l-table-light-border); | ||
| border-top: var(--d2l-table-border); |
There was a problem hiding this comment.
Cleaned up some CSS variable use while I was in here to better mirror the variables used in the Lit versions.
| --d2l-table-border-overflow: dashed 1px var(--d2l-color-mica); | ||
| --d2l-table-border-radius: 0.3rem; | ||
| --d2l-table-row-border-color-selected: var(--d2l-color-celestine); | ||
| --d2l-table-row-background-color-selected: var(--d2l-color-celestine-plus-2); |
There was a problem hiding this comment.
Merged these with what was in d2l-table-shared-styles.js and are defining them on the element instead of globally -- this matches how we do things in Lit as well.
| @@ -1,59 +1,31 @@ | |||
| <!doctype html> | |||
| <html> | |||
|
|
|||
There was a problem hiding this comment.
There'll be lots of diffs in the demo files due to the old Polymer 3 conversion process, but I've tried to keep them mostly the same.
| @@ -1,51 +0,0 @@ | |||
| <!doctype html> | |||
There was a problem hiding this comment.
Deleted this demo since we no longer support these style overrides anyway.
| @@ -1,74 +0,0 @@ | |||
| <!doctype html> | |||
There was a problem hiding this comment.
Deleted a bunch of the other demos as they were redundant with what we have already and were created for the old Galen tests.
There was a problem hiding this comment.
Yeah not super concerned with full coverage here if we have it in core and the idea is to slowly remove these usages anyways
| @@ -1 +1 @@ | |||
| * @awikkerink | |||
| * @dlockhart | |||
There was a problem hiding this comment.
Hopefully this is OK @awikkerink! Figured you'd be happy to be off these reviews haha.
There was a problem hiding this comment.
Yes, this is fine. I haven't been working on d2l-table for a while, and I'll be happy to let it go. It's been a pain from the beginning (curse you IE11 and IE10).
There was a problem hiding this comment.
Haha yes IE11 going away definitely allowed a lot of the code in here to simply be deleted.
|
🎉 This PR is included in version 2.8.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
ghost
added
the
3 participants
These changes switch the Polymer-based table web components over to use the newly added Lit ones from core (where possible).
The
<d2l-table>,<d2l-tr>, etc. elements are no longer necessary now that IE11 isn't supported, so they have not been migrated to Lit and were left mostly as-is.<d2l-table-wrapper>and<d2l-scroll-wrapper>are direct pass-throughs to the Lit versions, which will allow both the old and new to coexist.Inline comments to follow...