Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: facebook/react-native
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: main
Choose a base ref
...
head repository: BretJohnson/react-native
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 2 commits
  • 1 file changed
  • 1 contributor

Commits on Feb 27, 2016

  1. Added an environment variable, RCT_NO_LAUNCH_PACKAGER, that when set … 

    …makes

Xcode not the launch the packager when building. This switch is needed
for CI builds, where launching the packager, which stays running, causes
the build to hang; port conflicts can be an issue as well. Really the
packager is only appropriate for interactive developer builds.  This
is a problem for Visual Studio Team Services where we just added
React Native CI build support with a React Native build extension and
surely a problem for all CI systems.  This fix is simple, and now if
the build machine sets RCT_NO_LAUNCH_PACKAGER globally or passes
it as an arg to xcodebuild, the packager won't launch and all is well.
    Bret Johnson committed Feb 27, 2016
    Configuration menu
    Copy the full SHA
    2625e8e View commit details
    Browse the repository at this point in the history

Commits on May 18, 2016

  1. Merge branch 'master' into master

    Bret Johnson committed May 18, 2016
    Configuration menu
    Copy the full SHA
    737a7ed View commit details
    Browse the repository at this point in the history
Loading