This repository was archived by the owner on Feb 3, 2021. It is now read-only.
Merged
Conversation
brnleehng
reviewed
Aug 24, 2018
| ssh_key=ssh_key.exportKey().decode("utf-8"), | ||
| container_name=container_name, | ||
| timeout=timeout) | ||
| timeout=timeout, |
brnleehng
reviewed
Aug 24, 2018
| ssh_key=ssh_key.exportKey().decode("utf-8"), | ||
| container_name=container_name, | ||
| timeout=timeout)) | ||
| timeout=timeout, |
Contributor
There was a problem hiding this comment.
Remove comma after timeout
Member
Author
There was a problem hiding this comment.
This is part of the yapf style definition so it is auto formatted.
brnleehng
reviewed
Aug 24, 2018
| ssh_key=ssh_key.exportKey().decode("utf-8"), | ||
| container_name=container_name, | ||
| timeout=timeout) | ||
| timeout=timeout, |
Contributor
There was a problem hiding this comment.
Remove comma after timeout
brnleehng
reviewed
Aug 24, 2018
| ssh_key=ssh_key.exportKey().decode("utf-8"), | ||
| container_name=container_name, | ||
| timeout=timeout)) | ||
| timeout=timeout, |
Contributor
There was a problem hiding this comment.
Remove comma after timeout
brnleehng
reviewed
Aug 24, 2018
| "Please supply a valid (greater than 0) size or size_low_priority value either in the cluster.yaml configuration file or with a parameter (--size or --size-low-priority)" | ||
| ) | ||
| "Please supply a valid (greater than 0) size or size_low_priority value either " | ||
| "in the cluster.yaml configuration file or with a parameter (--size or --size-low-priority)") |
Contributor
There was a problem hiding this comment.
Shouldn't these two strings be concatenated?
brnleehng
reviewed
Aug 24, 2018
| "You must configure a VNET to use AZTK in mixed mode (dedicated and low priority nodes). Set the VNET's subnet_id in your cluster.yaml or with a parameter (--subnet-id)." | ||
| ) | ||
| "You must configure a VNET to use AZTK in mixed mode (dedicated and low priority nodes). " | ||
| "Set the VNET's subnet_id in your cluster.yaml or with a parameter (--subnet-id).") |
brnleehng
approved these changes
Aug 25, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Our CI build only look at pylint errors, not warnings. We let the number of warnings increase to the hundreds as a result. This PR will resolve (nearly) all pylint warnings.