Allow suppressing HTTPS filtering error notification

[ameshkov]

Problem Description

There is a request from users who want to suppress this notification and continue trying to filter HTTPS at the same time. While I don't think this behavior should be the default, it makes sense to allow it.

Proposed Solution

• Add a new low-level setting: pref.https.opportunistic.
• Add another one that is used for suppressing notifications: pref.https.ignored.errors
• Default value: true
• Change the HTTPS filtering notification buttons from "Exclude app" and "Exclude domain" to "Ignore app" and "Ignore domain". These buttons' behavior should depend on this low-level setting value.

pref.https.ignored.errors

It contains the list of apps and domains for which we do not show HTTPS filtering error notifications.

Example:

{
    domains: {
        "www.example.org": "application.name"
    },
    apps: [
        "package.name1",
        "package.name2",
    ]
}

• "Ignore app" -- adds an app to this setting.
• "Ignore domain" -- adds an app+domain pair to this setting.

pref.https.opportunistic

• pref.https.opportunistic==true (default)
  If enabled, AdGuard will bypass the traffic if the app does not accept our certificate.

• pref.https.opportunistic==false
  If disabled, AdGuard won't bypass traffic if the app does not accept our certificate (just like what we do with browsers).

[NauseBA]

Just from a users POV:
I liked a simple option "do not show for this app and domain anymore".
I added properties to apps (see app mgmt - you have an array of app/app-properties anyway, why not add "HTTPS error notification supressed domains"?)).

Disabling filtering should always be the very last resort to get an app to work, not the "solution" to suppress annoyances.

[ameshkov]

Disabling filtering should always be the very last resort to get an app to work, not the "solution" to suppress annoyances.

I have to disagree here. Breaking connections may be disastrous to the app and even to the device, and this is not really user-friendly. That's why I want to enable "opportunistic" behavior by default.

[NauseBA]

The enhancement I was asking for is just to get rid of those notifications (regarding this single app and those individual domains) whilst having no other change in functionality of Adguard.

Maybe have a look at "Notic" app to get an idea.

Besides: No.
"Breaking connections" is not "disastrous to [...] the device".
Connectivity greatly enhances a smartphones functionality but smartphones do even work w/o any internet connectivity at all.

So if a user prefers "crippled" app functionality over privacy loss it should be the users choice.

As you mentioned on Telegram: This is a power users choice. So the default should be "weaken privacy to retain functionality".
But how does it hurt a common user to have, besides "exclude app" and "exclude domain", a 3rd choice like "do not nag me again about this"?
OK, you fear support issues. So add a screen saying "I accept that $app may no longer work and will refrain from nagging Adguard Inc. about lost functionality"

Whatever floats your boat, my solution is Notic.

[ameshkov]

So if a user prefers "crippled" app functionality over privacy loss it should be the users choice.

And the proposed solution allows you to achieve this. My point is that this behavior is not the default.

[ameshkov]

OK, you fear support issues. So add a screen saying "I accept that $app may no longer work and will refrain from nagging Adguard Inc. about lost functionality"

This can be done later, we don't have much time left to add more functionality to v3.3 release.

[NauseBA]

Leave it to future versions, there is no need to include this into 3.3.