Treat unreachable code correctly, fix fallthrough in switch

Author: paceholder

src/ConnectionGraphicsObject.cpp

@@ -1,13 +1,5 @@
 #include "ConnectionGraphicsObject.hpp"
 
-#include <QtWidgets/QGraphicsSceneMouseEvent>
-#include <QtWidgets/QGraphicsDropShadowEffect>
-#include <QtWidgets/QGraphicsBlurEffect>
-#include <QtWidgets/QStyleOptionGraphicsItem>
-#include <QtWidgets/QGraphicsView>
-
-#include <QtCore/QDebug>
-
 #include "AbstractGraphModel.hpp"
 #include "AbstractNodeGeometry.hpp"
 #include "BasicGraphicsScene.hpp"
@@ -20,6 +12,16 @@
 #include "StyleCollection.hpp"
 #include "locateNode.hpp"
 
+#include <QtWidgets/QGraphicsSceneMouseEvent>
+#include <QtWidgets/QGraphicsDropShadowEffect>
+#include <QtWidgets/QGraphicsBlurEffect>
+#include <QtWidgets/QStyleOptionGraphicsItem>
+#include <QtWidgets/QGraphicsView>
+
+#include <QtCore/QDebug>
+
+#include <stdexcept>
+
 
 namespace QtNodes
 {
@@ -376,6 +378,8 @@ pointsC1C2() const
       return pointsC1C2Vertical();
       break;
   }
+
+  throw std::logic_error("Unreachable code after switch statement");
 }
 
 

src/DefaultVerticalNodeGeometry.cpp

@@ -360,6 +360,7 @@ portCaptionsHeight(NodeId const   nodeId,
           break;
         }
       }
+      break;
     }
 
     case PortType::Out:
@@ -377,6 +378,7 @@ portCaptionsHeight(NodeId const   nodeId,
           break;
         }
       }
+      break;
     }
 
     default: