Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NVDARemote/remote-server
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: nvaccess/remote-server
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: main
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 7 commits
  • 22 files changed
  • 4 contributors

Commits on Jun 18, 2025

  1. Update Tooling to match other NV Access projects

    * Add initial ruff configuration, based on that of NVDA
    
    (cherry picked from commit 30afec5)
    
    * Rename and improve ruff.toml
    
    (cherry picked from commit a3c8b7e)
    
    * Use UV as dependency orchestrator
    
    (cherry picked from commit 7874c97)
    
    * Enable pyright, with all failing tests disabled
    
    (cherry picked from commit d957dee)
    
    * Move to pyproject.toml for ruff config
    
    (cherry picked from commit 65ec5c5)
    
    * Update pre-commit config for CI
    
    (cherry picked from commit 736ab41)
    
    * Pre-commit updates
    
    (cherry picked from commit 39f2167)
    
    * Remove pyrightCI and remove pyrightLocal alias
    
    (cherry picked from commit 200e084)
    
    * Ran ruff over server and setup
    
    * Update readme
    
    * Downcase readme
    
    * Apply suggestions from code review
    
    Co-authored-by: Sean Budd <seanbudd123@gmail.com>
    
    ---------
    
    Co-authored-by: Sean Budd <seanbudd123@gmail.com>
    SaschaCowley and seanbudd authored Jun 18, 2025
    Configuration menu
    Copy the full SHA
    4478302 View commit details
    Browse the repository at this point in the history
  2. Add Unit Tests (#6)

    * Use UV as package manager (from remote-server@codeStandards)
    
    * Add coverage
    
    * Add initial test
    
    * Ensure creating users starts from a known baseline
    
    * Add tests for server state
    
    * Add test for single password generation
    
    * More test for key generation
    
    * Minor fixes to tests
    
    * Add .py,cover files to gitignore
    
    * Add coverage config to pyproject
    
    * Addd channel lifecycle tests
    
    * Refactor tests
    
    * Add tests for broadcast
    
    * Up test coverage threshold since we've passed 80% coverage
    
    * Add tests for channel.add_user
    
    * Add tests for channel
    
    * Add docstrings and rearrange
    
    * Exclude main, __name__=__main__, and tcpnodelay from coverage
    
    * Increase fail under to 95 as 90% coverage has been achieved
    
    * Add tests for ping_connected_clients
    
    * Add several tests
    
    * Slight refactor of tests
    
    * Coverage workflow
    
    * Update test workflow
    
    * Up the fail under to test failure for insufficient coverage
    
    * Set fail-under to 0 when generateing artifacts
    
    * Fix typo
    
    * Try github step summary
    
    * Apply suggestions from code review
    
    Co-authored-by: Sean Budd <seanbudd123@gmail.com>
    
    * Update .gitignore
    
    * Fix typo
    
    * Lint and format with ruff
    
    * Lower fail under to 95
    
    * Fix non dict message test case
    
    * Add more tests for user
    
    * Add test for MOTD
    
    * Branch coverage for channel join
    
    * Ignore intentionally untested code and partial branches
    
    * Up fail under to 100 again
    
    * Add comment
    
    * Clarify comment
    
    ---------
    
    Co-authored-by: Sean Budd <seanbudd123@gmail.com>
    SaschaCowley and seanbudd authored Jun 18, 2025
    Configuration menu
    Copy the full SHA
    48f4019 View commit details
    Browse the repository at this point in the history

Commits on Jun 24, 2025

  1. Update to follow our code standards more closely (#4)

    * Added editorconfig based on that in nvaccess/nvda
    
    * lf instead of crlf
    
    * Add initial ruff configuration, based on that of NVDA
    
    * remove explicit inheritance from `object`
    
    * Initial run ov monkeytype over the code base
    
    * Remove inheritance from object
    
    * Fix a couple of type annotations
    
    * Rename and improve ruff.toml
    
    * Fix up type annotations by removing Optional, Union, Dict, List etc
    
    * Read certificates as binary
    
    * Move type hints into server.py
    
    * Fix logging
    
    * Fix ambiguous name
    
    * Fix some typing issues
    
    * Docstrings for channel
    
    * Docstrings for Handler
    
    * Docstrings for User
    
    * Docstrings for ServerState
    
    * Add some comments
    
    * Enable pyright, with all failing tests disabled
    
    * Fix reportDeprecated
    
    * Fix unannotated functions
    
    * Resolved several type issues
    
    * Move to pyproject.toml for ruff config
    
    * Remove no longer needed type stubs
    
    * Update pre-commit config for CI
    
    * Pre-commit updates
    
    * Remove pyrightCI and remove pyrightLocal alias
    
    * Experimental pyright GHA
    
    * Try using uvx to run pyright
    
    * Update deps
    
    * Try running with uv run
    
    * Sync environment then use uvx
    
    * Include dev
    
    * Use uv run
    
    * Apply suggestions from code review
    
    Co-authored-by: Sean Budd <seanbudd123@gmail.com>
    
    * Update .github/workflows/pyright.yml
    
    Co-authored-by: Sean Budd <seanbudd123@gmail.com>
    
    * Fix pyright error in server.py
    
    * Fix typ annotations on test.TestGenerateKey._test
    
    * Silence pyright errors caused by incorrect types in ttwisted/Zope interfaces
    
    * Bring coverage back up to 100%
    
    * camelCase variables, methods and attributes in server.Channel
    
    * camelCase attributes, methods and variables in server.Handler
    
    * camelCase attributes, methods and variables in server.User
    
    * camelCase attributes, methods and variables in server.RemoteServerFactory
    
    * camelCase attributes, methods and variables in server.ServerState
    
    * Fix some straggling snake_case
    
    * Minor sweeks
    
    * Try using a composite setup action for coverage
    
    * Add default shell to actions/setup-environment
    
    * run -> runs
    
    * Move shell to steps with runs
    
    * Use setup-environment with pyright ci
    
    * Add pyright output to GHA summary
    
    * Test restricting perms
    
    * Test restricting perms
    
    * Restrict perms of pyright action
    
    ---------
    
    Co-authored-by: Sean Budd <seanbudd123@gmail.com>
    SaschaCowley and seanbudd authored Jun 24, 2025
    Configuration menu
    Copy the full SHA
    4be3369 View commit details
    Browse the repository at this point in the history

Commits on Jul 1, 2025

  1. Add the option to disable SSL (#8)

    This allows the webserver to handle TLS, which is more flexible than the solution used internally. This is the approach used by nvdaremote.com
    
    ---------
    
    Co-authored-by: Tyler Spivey <tspivey@pcdesk.net>
    SaschaCowley and tspivey authored Jul 1, 2025
    Configuration menu
    Copy the full SHA
    006cd53 View commit details
    Browse the repository at this point in the history

Commits on Jul 30, 2025

  1. Update containerization (#10)

    This PR:
    
    * Updates the Docker containerization to use our tooling (UV and Python 3.13).
    * Updates the Dockerfile to use build stages.
    * Adds Compose Watch support to the docker containerization, which enables seamless containerized DX.
    SaschaCowley authored Jul 30, 2025
    Configuration menu
    Copy the full SHA
    3d1f029 View commit details
    Browse the repository at this point in the history
  2. Add free software licence (AGPL3) (#9)

    * Add licence file
    
    * Add copyright notices to files
    
    * Fix double-space
    
    * Update copyright headers
    
    * Add the
    SaschaCowley authored Jul 30, 2025
    Configuration menu
    Copy the full SHA
    91239cb View commit details
    Browse the repository at this point in the history

Commits on Oct 23, 2025

  1. Configuration menu
    Copy the full SHA
    cf0203e View commit details
    Browse the repository at this point in the history
Loading