[ruby/prism] _finitef is unavailable on Windows x86

kddnewton · matzbot · commit c8dd0479553d · 2024-12-02T20:19:52.000Z
Instead cast it inline to a double on Windows. ruby/prism@9064d872aa
diff --git a/prism/defines.h b/prism/defines.h
@@ -136,17 +136,6 @@
 #   define PRISM_HAS_FILESYSTEM
 #endif
 
-/**
- * isinf on Windows is defined as accepting a float, but on POSIX systems it
- * accepts a float, a double, or a long double. We want to mirror this behavior
- * on windows.
- */
-#ifdef _WIN32
-#   include <float.h>
-#   undef isinf
-#   define isinf(x) (sizeof(x) == sizeof(float) ? !_finitef(x) : !_finite(x))
-#endif
-
 /**
  * If you build prism with a custom allocator, configure it with
  * "-D PRISM_XALLOCATOR" to use your own allocator that defines xmalloc,
diff --git a/prism/prism.c b/prism/prism.c
@@ -4142,7 +4142,14 @@ pm_double_parse(pm_parser_t *parser, const pm_token_t *token) {
 
     // If errno is set, then it should only be ERANGE. At this point we need to
     // check if it's infinity (it should be).
-    if (errno == ERANGE && isinf(value)) {
+    if (
+        errno == ERANGE &&
+#ifdef _WIN32
+        !_finite(value)
+#else
+        isinf(value)
+#endif
+    ) {
         int warn_width;
         const char *ellipsis;
 
diff --git a/prism/static_literals.c b/prism/static_literals.c
@@ -501,7 +501,13 @@ pm_static_literal_inspect_node(pm_buffer_t *buffer, const pm_static_literals_met
         case PM_FLOAT_NODE: {
             const double value = ((const pm_float_node_t *) node)->value;
 
-            if (isinf(value)) {
+            if (
+#ifdef _WIN32
+                !_finite(value)
+#else
+                isinf(value)
+#endif
+            ) {
                 if (*node->location.start == '-') {
                     pm_buffer_append_byte(buffer, '-');
                 }
