* compar.c (cmp_eq_recursive): Fix the return value, the value for

eregon · eregon · commit 7e978b1070bc · 2013-12-28T22:28:39.000Z
failed #<=> should be nil. It was raising a NoMethodError for the test case TestComparable#test_no_cmp (undefined method `>' for false:FalseClass). Yet one more reason for #7688. git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@44453 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
diff --git a/ChangeLog b/ChangeLog
@@ -1,3 +1,10 @@
+Sun Dec 29 07:27:51 2013  Benoit Daloze  <eregontp@gmail.com>
+
+	* compar.c (cmp_eq_recursive): Fix the return value, the value for
+	  failed #<=> should be nil. It was raising a NoMethodError for
+	  the test case TestComparable#test_no_cmp (undefined method `>'
+	  for false:FalseClass). Yet one more reason for #7688.
+
 Sat Dec 28 22:21:59 2013  Benoit Daloze  <eregontp@gmail.com>
 
 	* object.c (Kernel#<=>) surround Comparable operators with <code> tags.
diff --git a/compar.c b/compar.c
@@ -54,7 +54,7 @@ rb_invcmp(VALUE x, VALUE y)
 static VALUE
 cmp_eq_recursive(VALUE arg1, VALUE arg2, int recursive)
 {
-    if (recursive) return Qfalse;
+    if (recursive) return Qnil;
     return rb_funcallv(arg1, cmp, 1, &arg2);
 }
 

Original file line number	Diff line number	Diff line change
`@@ -54,7 +54,7 @@ rb_invcmp(VALUE x, VALUE y)`
`54`	`54`	`static VALUE`
`55`	`55`	`cmp_eq_recursive(VALUE arg1, VALUE arg2, int recursive)`
`56`	`56`	`{`
`57`		`- if (recursive) return Qfalse;`
	`57`	`+ if (recursive) return Qnil;`
`58`	`58`	`return rb_funcallv(arg1, cmp, 1, &arg2);`
`59`	`59`	`}`
`60`	`60`