[Feature #19163] Marshal-loaded Data object also should be frozen

nobu · nobu · commit 5872fd6f6cc5 · 2022-12-02T00:56:52.000+09:00
diff --git a/struct.c b/struct.c
@@ -786,6 +786,7 @@ VALUE
 rb_struct_initialize(VALUE self, VALUE values)
 {
     rb_struct_initialize_m(RARRAY_LENINT(values), RARRAY_CONST_PTR(values), self);
+    if (rb_obj_is_kind_of(self, rb_cData)) OBJ_FREEZE_RAW(self);
     RB_GC_GUARD(values);
     return Qnil;
 }
diff --git a/test/ruby/test_data.rb b/test/ruby/test_data.rb
@@ -177,4 +177,14 @@ def test_dup
     assert_equal(klass.new(foo: 1, bar: 2), test.dup)
     assert_predicate(test.dup, :frozen?)
   end
+
+  Klass = Data.define(:foo, :bar)
+
+  def test_marshal
+    test = Klass.new(foo: 1, bar: 2)
+    loaded = Marshal.load(Marshal.dump(test))
+    assert_equal(test, loaded)
+    assert_not_same(test, loaded)
+    assert_predicate(loaded, :frozen?)
+  end
 end

Original file line number	Diff line number	Diff line change
`@@ -786,6 +786,7 @@ VALUE`
`786`	`786`	`rb_struct_initialize(VALUE self, VALUE values)`
`787`	`787`	`{`
`788`	`788`	`rb_struct_initialize_m(RARRAY_LENINT(values), RARRAY_CONST_PTR(values), self);`
	`789`	`+ if (rb_obj_is_kind_of(self, rb_cData)) OBJ_FREEZE_RAW(self);`
`789`	`790`	`RB_GC_GUARD(values);`
`790`	`791`	`return Qnil;`
`791`	`792`	`}`