* array.c (rb_ary_s_create): no need for negative argc check.

matz · matz · commit 3d4376d16777 · 2005-02-23T13:52:19.000Z
[ruby-core:04463]

* array.c (rb_ary_unshift_m): ditto.

* lib/xmlrpc/parser.rb (XMLRPC::FaultException): make it subclass
  of StandardError class, not Exception class.  [ruby-core:04429]

* lib/open3.rb (Open3::popen3): $? should not be EXIT_FAILURE.
  fixed: [ruby-core:04444]


git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_1_8@8028 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
diff --git a/ChangeLog b/ChangeLog
@@ -3,6 +3,13 @@ Thu Feb 23 15:04:32 2005  akira yamada  <akira@ruby-lang.org>
 	* lib/uri/generic.rb (split_userinfo): should split ":pass" into ""
 	  and "pass".  [ruby-dev:25667]
 
+Wed Feb 23 08:00:18 2005  Yukihiro Matsumoto  <matz@ruby-lang.org>
+
+	* array.c (rb_ary_s_create): no need for negative argc check.
+	  [ruby-core:04463]
+
+	* array.c (rb_ary_unshift_m): ditto.
+
 Wed Feb 23 01:57:46 2005  Shugo Maeda  <shugo@ruby-lang.org>
 
 	* lib/net/imap.rb (initialize): handle certs correctly. Thanks,
@@ -55,6 +62,11 @@ Sat Feb 19 01:32:03 2005  Hirokazu Yamamoto  <ocean@m2.ccsnet.ne.jp>
 	* ext/bigdecimal/lib/bigdecimal/nlsolve.rb: removed because this file
 	  is sample script and same file exists in ext/bigdecimal/sample.
 
+Fri Feb 18 17:14:00 2005  Yukihiro Matsumoto  <matz@ruby-lang.org>
+
+	* lib/xmlrpc/parser.rb (XMLRPC::FaultException): make it subclass
+	  of StandardError class, not Exception class.  [ruby-core:04429]
+
 Thu Feb 17 20:11:18 2005  Hirokazu Yamamoto  <ocean@m2.ccsnet.ne.jp>
 
 	* lib/drb/drb.rb (DRbServer.default_safe_level): fix typo.
@@ -75,6 +87,11 @@ Thu Feb 17 11:54:00 2005  Nathaniel Talbott  <ntalbott@ruby-lang.org>
 
 	* lib/test/unit.rb: ditto.
 
+Thu Feb 17 04:21:47 2005  Yukihiro Matsumoto  <matz@ruby-lang.org>
+
+	* lib/open3.rb (Open3::popen3): $? should not be EXIT_FAILURE.
+	  fixed: [ruby-core:04444]
+
 Thu Feb 17 00:09:45 2005  Masatoshi SEKI  <m_seki@mva.biglobe.ne.jp>
 
 	* test/drb/ignore_test_drb.rb: move TestDRbReusePort to new file
diff --git a/array.c b/array.c
@@ -334,9 +334,6 @@ rb_ary_s_create(argc, argv, klass)
 {
     VALUE ary = ary_alloc(klass);
 
-    if (argc < 0) {
-	rb_raise(rb_eArgError, "negative number of arguments");
-    }
     if (argc > 0) {
 	RARRAY(ary)->ptr = ALLOC_N(VALUE, argc);
 	MEMCPY(RARRAY(ary)->ptr, argv, VALUE, argc);
@@ -552,9 +549,6 @@ rb_ary_unshift_m(argc, argv, ary)
 {
     long len = RARRAY(ary)->len;
 
-    if (argc < 0) {
-	rb_raise(rb_eArgError, "negative number of arguments");
-    }
     if (argc == 0) return ary;
 
     /* make rooms by setting the last item */
diff --git a/lib/open3.rb b/lib/open3.rb
@@ -35,7 +35,7 @@ def popen3(*cmd)
 
 	exec(*cmd)
       }
-      exit!
+      exit!(0)
     }
 
     pw[0].close
diff --git a/lib/xmlrpc/parser.rb b/lib/xmlrpc/parser.rb
@@ -51,7 +51,7 @@ def nodeName
 
 module XMLRPC
 
-  class FaultException < Exception
+  class FaultException < StandardError
     attr_reader :faultCode, :faultString
 
     def initialize(faultCode, faultString)
diff --git a/process.c b/process.c
@@ -1539,13 +1539,13 @@ rb_f_system(argc, argv)
 
 /*
  *  call-seq:
- *     sleep(duration=0)    => fixnum
+ *     sleep([duration])    => fixnum
  *  
  *  Suspends the current thread for _duration_ seconds (which may be
  *  any number, including a +Float+ with fractional seconds). Returns the actual
  *  number of seconds slept (rounded), which may be less than that asked
  *  for if the thread was interrupted by a +SIGALRM+, or if
- *  another thread calls <code>Thread#run</code>. An argument of zero
+ *  another thread calls <code>Thread#run</code>. Zero arguments
  *  causes +sleep+ to sleep forever.
  *     
  *     Time.new    #=> Wed Apr 09 08:56:32 CDT 2003
diff --git a/sample/test.rb b/sample/test.rb
@@ -787,10 +787,10 @@ def r(val); a,b,*c = *yield(); test_ok([a,b,c] == val, 2); end
 test_ok($x.values_at(2,3) == [4,6])
 test_ok($x == {1=>2, 2=>4, 3=>6})
 
-$z = $y.keys.join(":")
+$z = $y.keys.sort.join(":")
 test_ok($z == "1:2:3")
 
-$z = $y.values.join(":")
+$z = $y.values.sort.join(":")
 test_ok($z == "2:4:6")
 test_ok($x == $y)
 

Original file line number	Diff line number	Diff line change
`@@ -35,7 +35,7 @@ def popen3(*cmd)`
`35`	`35`
`36`	`36`	`exec(*cmd)`
`37`	`37`	`}`
`38`		`- exit!`
	`38`	`+ exit!(0)`
`39`	`39`	`}`
`40`	`40`
`41`	`41`	`pw[0].close`