merge revision(s) 496591d: [Backport #18578]

unak · unak · commit 334ca2dc0693 · 2022-03-19T22:50:51.000+09:00
st.c: Do not clear entries_bound when calling Hash#shift for empty
     hash

    tab-&gt;entries_bound is used to check if the bins are full in
    rebuild_table_if_necessary.

    Hash#shift against an empty hash assigned 0 to tab-&gt;entries_bound, but
    didn't clear the bins. Thus, the table is not rebuilt even when the bins
    are full. Attempting to add a new element into full-bin hash gets stuck.

    This change stops clearing tab-&gt;entries_bound in Hash#shift.
    [Bug #18578]
    ---
     st.c                   |  1 -
     test/ruby/test_hash.rb | 13 +++++++++++++
     2 files changed, 13 insertions(+), 1 deletion(-)
diff --git a/st.c b/st.c
@@ -1486,7 +1486,6 @@ st_shift(st_table *tab, st_data_t *key, st_data_t *value)
 	}
     }
     st_assert(tab->num_entries == 0);
-    tab->entries_start = tab->entries_bound = 0;
     if (value != 0) *value = 0;
     return 0;
 }
diff --git a/test/ruby/test_hash.rb b/test/ruby/test_hash.rb
@@ -983,6 +983,19 @@ def h.default(k = nil)
     assert_equal("FOO", h.shift)
   end
 
+  def test_shift_for_empty_hash
+    # [ruby-dev:51159]
+    h = @cls[]
+    100.times{|n|
+      while h.size < n
+        k = Random.rand 0..1<<30
+        h[k] = 1
+      end
+      0 while h.shift
+      assert_equal({}, h)
+    }
+  end
+
   def test_reject_bang2
     assert_equal({1=>2}, @cls[1=>2,3=>4].reject! {|k, v| k + v == 7 })
     assert_nil(@cls[1=>2,3=>4].reject! {|k, v| k == 5 })
diff --git a/version.h b/version.h
@@ -2,7 +2,7 @@
 # define RUBY_VERSION_MINOR RUBY_API_VERSION_MINOR
 #define RUBY_VERSION_TEENY 6
 #define RUBY_RELEASE_DATE RUBY_RELEASE_YEAR_STR"-"RUBY_RELEASE_MONTH_STR"-"RUBY_RELEASE_DAY_STR
-#define RUBY_PATCHLEVEL 217
+#define RUBY_PATCHLEVEL 218
 
 #define RUBY_RELEASE_YEAR 2022
 #define RUBY_RELEASE_MONTH 3

Original file line number	Diff line number	Diff line change
`@@ -1486,7 +1486,6 @@ st_shift(st_table tab, st_data_t key, st_data_t *value)`
`1486`	`1486`	`}`
`1487`	`1487`	`}`
`1488`	`1488`	`st_assert(tab->num_entries == 0);`
`1489`		`- tab->entries_start = tab->entries_bound = 0;`
`1490`	`1489`	`if (value != 0) *value = 0;`
`1491`	`1490`	`return 0;`
`1492`	`1491`	`}`