[rubygems/rubygems] Deprecate bundle cache --frozen and bundle cache --no-prune

deivid-rodriguez · hsbt · commit 2d3fd1fd2841 · 2025-09-03T23:38:37.000+09:00
Since they are remembered flags, too. I also restored a previous spec about `--frozen`, but didn't bother with `--no-prune`. rubygems/rubygems@7802f016fc
diff --git a/lib/bundler/cli.rb b/lib/bundler/cli.rb
@@ -415,6 +415,10 @@ def cache
       print_remembered_flag_deprecation("--all", "cache_all", "true") if ARGV.include?("--all")
       print_remembered_flag_deprecation("--no-all", "cache_all", "false") if ARGV.include?("--no-all")
 
+      %w[frozen no-prune].each do |option|
+        remembered_flag_deprecation(option)
+      end
+
       if flag_passed?("--path")
         message =
           "The `--path` flag is deprecated because its semantics are unclear. " \
diff --git a/spec/bundler/commands/cache_spec.rb b/spec/bundler/commands/cache_spec.rb
@@ -290,6 +290,39 @@
     end
   end
 
+  it "enforces frozen mode when --frozen is passed" do
+    gemfile <<-G
+      source "https://gem.repo1"
+      gem "myrack"
+      gem "myrack-obama"
+    G
+
+    lockfile <<-L
+      GEM
+        remote: https://gem.repo1/
+        specs:
+          myrack (1.0.0)
+
+      PLATFORMS
+        #{lockfile_platforms}
+
+      DEPENDENCIES
+        myrack
+
+      BUNDLED WITH
+         #{Bundler::VERSION}
+    L
+
+    bundle "cache --frozen", raise_on_error: false
+
+    expect(exitstatus).to eq(16)
+    expect(err).to include("frozen mode")
+    expect(err).to include("You have added to the Gemfile")
+    expect(err).to include("* myrack-obama")
+    bundle "env"
+    expect(out).to include("frozen")
+  end
+
   context "with frozen configured" do
     let(:app_cache) { bundled_app("vendor/cache") }
 
diff --git a/spec/bundler/other/major_deprecation_spec.rb b/spec/bundler/other/major_deprecation_spec.rb
@@ -265,6 +265,50 @@
     pending "fails with a helpful error", bundler: "4"
   end
 
+  context "bundle cache --frozen" do
+    before do
+      install_gemfile <<-G
+        source "https://gem.repo1"
+        gem "myrack"
+      G
+
+      bundle "cache --frozen", raise_on_error: false
+    end
+
+    it "should print a deprecation warning" do
+      expect(deprecations).to include(
+        "The `--frozen` flag is deprecated because it relies on being " \
+        "remembered across bundler invocations, which bundler will no " \
+        "longer do in future versions. Instead please use `bundle config set " \
+        "frozen true`, and stop using this flag"
+      )
+    end
+
+    pending "fails with a helpful error", bundler: "4"
+  end
+
+  context "bundle cache --no-prune" do
+    before do
+      install_gemfile <<-G
+        source "https://gem.repo1"
+        gem "myrack"
+      G
+
+      bundle "cache --no-prune", raise_on_error: false
+    end
+
+    it "should print a deprecation warning" do
+      expect(deprecations).to include(
+        "The `--no-prune` flag is deprecated because it relies on being " \
+        "remembered across bundler invocations, which bundler will no " \
+        "longer do in future versions. Instead please use `bundle config set " \
+        "no_prune true`, and stop using this flag"
+      )
+    end
+
+    pending "fails with a helpful error", bundler: "4"
+  end
+
   describe "bundle config" do
     describe "old list interface" do
       before do
