add tag v2_4_0_preview2

nurse · nurse · commit 277d1f50bb04 · 2016-09-09T00:20:57.000Z
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/tags/v2_4_0_preview2@56114 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
diff --git a/ChangeLog b/ChangeLog
@@ -1,3 +1,19 @@
+Thu Sep  8 17:47:18 2016  Kazuki Tsujimoto  <kazuki@callcc.net>
+
+	* array.c (flatten): use rb_obj_class instead of rb_class_of
+	  because rb_class_of may return a singleton class.
+	  [ruby-dev:49781] [Bug #12738]
+
+Thu Sep  8 17:40:15 2016  Nobuyoshi Nakada  <nobu@ruby-lang.org>
+
+	* tool/rbinstall.rb (gem): use the bindir of each gemspec instead
+	  of hardcoded 'bin', since rdoc 5.0.0 overrides it.
+
+Thu Sep  8 16:47:03 2016  Shugo Maeda  <shugo@ruby-lang.org>
+
+	* eval.c (rb_mod_s_used_modules): rename Module.used_refinements to
+	  Module.used_modules.  [Feature #7418] [ruby-core:49805]
+
 Thu Sep  8 14:21:48 2016  SHIBATA Hiroshi  <hsbt@ruby-lang.org>
 
 	* ext/psych/psych.gemspec, lib/rdoc/rdoc.gemspec: Use file list instead of
diff --git a/array.c b/array.c
@@ -4583,7 +4583,7 @@ flatten(VALUE ary, int level, int *modified)
 
     st_free_table(memo);
 
-    RBASIC_SET_CLASS(result, rb_class_of(ary));
+    RBASIC_SET_CLASS(result, rb_obj_class(ary));
     return result;
 }
 
diff --git a/eval.c b/eval.c
@@ -1312,7 +1312,7 @@ mod_using(VALUE self, VALUE module)
 }
 
 static int
-used_refinements_i(VALUE _, VALUE mod, VALUE ary)
+used_modules_i(VALUE _, VALUE mod, VALUE ary)
 {
     ID id_defined_at;
     CONST_ID(id_defined_at, "__defined_at__");
@@ -1325,10 +1325,10 @@ used_refinements_i(VALUE _, VALUE mod, VALUE ary)
 
 /*
  *  call-seq:
- *     used_refinements -> array
+ *     used_modules -> array
  *
- *  Returns an array of all active refinements in the current scope. The
- *  ordering of modules in the resulting array is not defined.
+ *  Returns an array of all modules used in the current scope. The ordering
+ *  of modules in the resulting array is not defined.
  *
  *     module A
  *       refine Object do
@@ -1342,21 +1342,21 @@ used_refinements_i(VALUE _, VALUE mod, VALUE ary)
  *
  *     using A
  *     using B
- *     p Module.used_refinements
+ *     p Module.used_modules
  *
  *  <em>produces:</em>
  *
  *     [B, A]
  */
 static VALUE
-rb_mod_s_used_refinements(void)
+rb_mod_s_used_modules(void)
 {
     const rb_cref_t *cref = rb_vm_cref();
     VALUE ary = rb_ary_new();
 
     while(cref) {
 	if(!NIL_P(CREF_REFINEMENTS(cref))) {
-	    rb_hash_foreach(CREF_REFINEMENTS(cref), used_refinements_i, ary);
+	    rb_hash_foreach(CREF_REFINEMENTS(cref), used_modules_i, ary);
 	}
 	cref = CREF_NEXT(cref);
     }
@@ -1698,8 +1698,8 @@ Init_eval(void)
     rb_define_private_method(rb_cModule, "prepend_features", rb_mod_prepend_features, 1);
     rb_define_private_method(rb_cModule, "refine", rb_mod_refine, 1);
     rb_define_private_method(rb_cModule, "using", mod_using, 1);
-    rb_define_singleton_method(rb_cModule, "used_refinements",
-			       rb_mod_s_used_refinements, 0);
+    rb_define_singleton_method(rb_cModule, "used_modules",
+			       rb_mod_s_used_modules, 0);
     rb_undef_method(rb_cClass, "refine");
 
     rb_undef_method(rb_cClass, "module_function");
diff --git a/io.c b/io.c
@@ -7716,7 +7716,7 @@ rb_file_initialize(int argc, VALUE *argv, VALUE io)
 	rb_raise(rb_eRuntimeError, "reinitializing File");
     }
     if (0 < argc && argc < 3) {
-	VALUE fd = rb_check_convert_type(argv[0], T_FIXNUM, "Fixnum", "to_int");
+	VALUE fd = rb_check_to_int(argv[0]);
 
 	if (!NIL_P(fd)) {
 	    argv[0] = fd;
diff --git a/test/ruby/test_array.rb b/test/ruby/test_array.rb
@@ -813,6 +813,15 @@ def test_flatten_splat
     assert_nothing_raised(RuntimeError, bug10748) {a.flatten(1)}
   end
 
+  def test_flattern_singleton_class
+    bug12738 = '[ruby-dev:49781] [Bug #12738]'
+    a = [[0]]
+    class << a
+      def m; end
+    end
+    assert_raise(NoMethodError, bug12738) { a.flatten.m }
+  end
+
   def test_flatten!
     a1 = @cls[ 1, 2, 3]
     a2 = @cls[ 5, 6 ]
@@ -850,6 +859,15 @@ def test_flatten_splat!
     assert_nothing_raised(RuntimeError, bug10748) {a.flatten!(1)}
   end
 
+  def test_flattern_singleton_class!
+    bug12738 = '[ruby-dev:49781] [Bug #12738]'
+    a = [[0]]
+    class << a
+      def m; end
+    end
+    assert_nothing_raised(NameError, bug12738) { a.flatten!.m }
+  end
+
   def test_flatten_with_callcc
     need_continuation
     o = Object.new
diff --git a/test/ruby/test_refinement.rb b/test/ruby/test_refinement.rb
@@ -1651,27 +1651,27 @@ def in_ref_c
 
     module Foo
       using RefB
-      USED_REFS = Module.used_refinements
+      USED_MODS = Module.used_modules
     end
 
     module Bar
       using RefC
-      USED_REFS = Module.used_refinements
+      USED_MODS = Module.used_modules
     end
 
     module Combined
       using RefA
       using RefB
-      USED_REFS = Module.used_refinements
+      USED_MODS = Module.used_modules
     end
   end
 
-  def test_used_refinements
+  def test_used_modules
     ref = VisibleRefinements
-    assert_equal [], Module.used_refinements
-    assert_equal [ref::RefB], ref::Foo::USED_REFS
-    assert_equal [ref::RefC], ref::Bar::USED_REFS
-    assert_equal [ref::RefB, ref::RefA], ref::Combined::USED_REFS
+    assert_equal [], Module.used_modules
+    assert_equal [ref::RefB], ref::Foo::USED_MODS
+    assert_equal [ref::RefC], ref::Bar::USED_MODS
+    assert_equal [ref::RefB, ref::RefA], ref::Combined::USED_MODS
   end
 
   def test_warn_setconst_in_refinmenet
diff --git a/tool/rbinstall.rb b/tool/rbinstall.rb
@@ -727,7 +727,7 @@ class Gem::Installer
     end
 
     unless gemspec.executables.empty? then
-      bin_dir = File.join(gem_dir, 'gems', full_name, 'bin')
+      bin_dir = File.join(gem_dir, 'gems', full_name, gemspec.bindir)
       makedirs(bin_dir)
 
       execs = gemspec.executables.map {|exec| File.join(srcdir, 'bin', exec)}

Original file line number	Diff line number	Diff line change
`@@ -4583,7 +4583,7 @@ flatten(VALUE ary, int level, int *modified)`
`4583`	`4583`
`4584`	`4584`	`st_free_table(memo);`
`4585`	`4585`
`4586`		`- RBASIC_SET_CLASS(result, rb_class_of(ary));`
	`4586`	`+ RBASIC_SET_CLASS(result, rb_obj_class(ary));`
`4587`	`4587`	`return result;`
`4588`	`4588`	`}`
`4589`	`4589`
Original file line number	Diff line number	Diff line change
`@@ -1312,7 +1312,7 @@ mod_using(VALUE self, VALUE module)`
`1312`	`1312`	`}`
`1313`	`1313`
`1314`	`1314`	`static int`
`1315`		`-used_refinements_i(VALUE _, VALUE mod, VALUE ary)`
	`1315`	`+used_modules_i(VALUE _, VALUE mod, VALUE ary)`
`1316`	`1316`	`{`
`1317`	`1317`	`ID id_defined_at;`
`1318`	`1318`	`CONST_ID(id_defined_at, "__defined_at__");`
`@@ -1325,10 +1325,10 @@ used_refinements_i(VALUE _, VALUE mod, VALUE ary)`
`1325`	`1325`
`1326`	`1326`	`/*`
`1327`	`1327`	`* call-seq:`
`1328`		`- * used_refinements -> array`
	`1328`	`+ * used_modules -> array`
`1329`	`1329`	`*`
`1330`		`- * Returns an array of all active refinements in the current scope. The`
`1331`		`- * ordering of modules in the resulting array is not defined.`
	`1330`	`+ * Returns an array of all modules used in the current scope. The ordering`
	`1331`	`+ * of modules in the resulting array is not defined.`
`1332`	`1332`	`*`
`1333`	`1333`	`* module A`
`1334`	`1334`	`* refine Object do`
`@@ -1342,21 +1342,21 @@ used_refinements_i(VALUE _, VALUE mod, VALUE ary)`
`1342`	`1342`	`*`
`1343`	`1343`	`* using A`
`1344`	`1344`	`* using B`
`1345`		`- * p Module.used_refinements`
	`1345`	`+ * p Module.used_modules`
`1346`	`1346`	`*`
`1347`	`1347`	`* <em>produces:</em>`
`1348`	`1348`	`*`
`1349`	`1349`	`* [B, A]`
`1350`	`1350`	`*/`
`1351`	`1351`	`static VALUE`
`1352`		`-rb_mod_s_used_refinements(void)`
	`1352`	`+rb_mod_s_used_modules(void)`
`1353`	`1353`	`{`
`1354`	`1354`	`const rb_cref_t *cref = rb_vm_cref();`
`1355`	`1355`	`VALUE ary = rb_ary_new();`
`1356`	`1356`
`1357`	`1357`	`while(cref) {`
`1358`	`1358`	`if(!NIL_P(CREF_REFINEMENTS(cref))) {`
`1359`		`- rb_hash_foreach(CREF_REFINEMENTS(cref), used_refinements_i, ary);`
	`1359`	`+ rb_hash_foreach(CREF_REFINEMENTS(cref), used_modules_i, ary);`
`1360`	`1360`	`}`
`1361`	`1361`	`cref = CREF_NEXT(cref);`
`1362`	`1362`	`}`
`@@ -1698,8 +1698,8 @@ Init_eval(void)`
`1698`	`1698`	`rb_define_private_method(rb_cModule, "prepend_features", rb_mod_prepend_features, 1);`
`1699`	`1699`	`rb_define_private_method(rb_cModule, "refine", rb_mod_refine, 1);`
`1700`	`1700`	`rb_define_private_method(rb_cModule, "using", mod_using, 1);`
`1701`		`- rb_define_singleton_method(rb_cModule, "used_refinements",`
`1702`		`- rb_mod_s_used_refinements, 0);`
	`1701`	`+ rb_define_singleton_method(rb_cModule, "used_modules",`
	`1702`	`+ rb_mod_s_used_modules, 0);`
`1703`	`1703`	`rb_undef_method(rb_cClass, "refine");`
`1704`	`1704`
`1705`	`1705`	`rb_undef_method(rb_cClass, "module_function");`
Original file line number	Diff line number	Diff line change
`@@ -7716,7 +7716,7 @@ rb_file_initialize(int argc, VALUE *argv, VALUE io)`
`7716`	`7716`	`rb_raise(rb_eRuntimeError, "reinitializing File");`
`7717`	`7717`	`}`
`7718`	`7718`	`if (0 < argc && argc < 3) {`
`7719`		`- VALUE fd = rb_check_convert_type(argv[0], T_FIXNUM, "Fixnum", "to_int");`
	`7719`	`+ VALUE fd = rb_check_to_int(argv[0]);`
`7720`	`7720`
`7721`	`7721`	`if (!NIL_P(fd)) {`
`7722`	`7722`	`argv[0] = fd;`