Skip to content

Commit 1d08109

Browse files
committed
merges r21188 from trunk into ruby_1_9_1.
Imported minitest 1.3.1 r4506. git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_1_9_1@21201 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
1 parent 3dbaf1e commit 1d08109

File tree

3 files changed

+60
-5
lines changed

3 files changed

+60
-5
lines changed

ChangeLog

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,8 @@
1+
Tue Dec 30 18:23:10 2008 Ryan Davis <ryand-ruby@zenspider.com>
2+
3+
* lib/minitest/*.rb: Imported minitest 1.3.1 r4506.
4+
* test/minitest/*.rb: ditto.
5+
16
Tue Dec 30 17:59:59 2008 Martin Duerst <duerst@it.aoyama.ac.jp>
27

38
* transcode.c: Minor fixes and tweaks in documentation.
@@ -165,7 +170,7 @@ Sun Dec 28 10:28:04 2008 Yusuke Endoh <mame@tsg.ne.jp>
165170
* thread.c (mutex_unlock, rb_mutex_unlock, rb_mutex_unlock_all):
166171
mutex_unlock receives a thread.
167172

168-
Sun Dec 28 05:44:44 2008 Ryan Davis <ryan@wrath.local>
173+
Sun Dec 28 05:44:44 2008 Ryan Davis <ryand-ruby@zenspider.com>
169174

170175
* lib/minitest/*.rb: Imported minitest 1.3.1 r4505.
171176
* test/minitest/*.rb: ditto.
@@ -3610,7 +3615,7 @@ Fri Oct 10 17:26:50 2008 NARUSE, Yui <naruse@ruby-lang.org>
36103615
* ext/json/ext/parser/parser.c (JSON_parse_string):
36113616
associate encoding.
36123617

3613-
Fri Oct 10 10:18:21 2008 Ryan Davis <ryan@wrath.local>
3618+
Fri Oct 10 10:18:21 2008 Ryan Davis <ryand-ruby@zenspider.com>
36143619

36153620
* lib/test/*: reverted back to test/unit.
36163621
* test/test/*: ditto
@@ -13006,7 +13011,7 @@ Tue Jun 17 20:32:37 2008 Nobuyoshi Nakada <nobu@ruby-lang.org>
1300613011
miniruby, and tests, debug, etc have no meaning when
1300713012
cross-compiling.
1300813013

13009-
Tue Jun 17 18:39:11 2008 Ryan Davis <ryan@wrath.local>
13014+
Tue Jun 17 18:39:11 2008 Ryan Davis <ryand-ruby@zenspider.com>
1301013015

1301113016
* common.mk: fixed dependencies on miniruby.
1301213017

lib/minitest/unit.rb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -119,7 +119,7 @@ def assert_match exp, act, msg = nil
119119
msg = message(msg) { "Expected #{mu_pp(exp)} to match #{mu_pp(act)}" }
120120
assert_respond_to act, :"=~"
121121
exp = /#{Regexp.escape(exp)}/ if String === exp && String === act
122-
assert act =~ exp, msg
122+
assert exp =~ act, msg
123123
end
124124

125125
def assert_nil obj, msg = nil
@@ -283,7 +283,7 @@ def refute_match exp, act, msg = nil
283283
msg = message(msg) { "Expected #{mu_pp(exp)} to not match #{mu_pp(act)}" }
284284
assert_respond_to act, :"=~"
285285
exp = /#{Regexp.escape(exp)}/ if String === exp && String === act
286-
refute act =~ exp, msg
286+
refute exp =~ act, msg
287287
end
288288

289289
def refute_nil obj, msg = nil

test/minitest/test_mini_test.rb

Lines changed: 50 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -535,6 +535,27 @@ def test_assert_match
535535
@tc.assert_match(/\w+/, "blah blah blah")
536536
end
537537

538+
def test_assert_match_object
539+
@assertion_count = 2
540+
541+
pattern = Object.new
542+
def pattern.=~(other) true end
543+
544+
@tc.assert_match pattern, 5
545+
end
546+
547+
def test_assert_match_object_triggered
548+
@assertion_count = 2
549+
550+
pattern = Object.new
551+
def pattern.=~(other) false end
552+
def pattern.inspect; "<<Object>>" end
553+
554+
util_assert_triggered 'Expected <<Object>> to match 5.' do
555+
@tc.assert_match pattern, 5
556+
end
557+
end
558+
538559
def test_assert_match_triggered
539560
@assertion_count = 2
540561
util_assert_triggered 'Expected /\d+/ to match "blah blah blah".' do
@@ -866,6 +887,35 @@ def test_refute_match
866887
@tc.refute_match(/\d+/, "blah blah blah")
867888
end
868889

890+
def test_refute_match_object
891+
@assertion_count = 2
892+
@tc.refute_match Object.new, 5 # default #=~ returns false
893+
end
894+
895+
def test_assert_object_triggered
896+
@assertion_count = 2
897+
898+
pattern = Object.new
899+
def pattern.=~(other) false end
900+
def pattern.inspect; "<<Object>>" end
901+
902+
util_assert_triggered 'Expected <<Object>> to match 5.' do
903+
@tc.assert_match pattern, 5
904+
end
905+
end
906+
907+
def test_refute_match_object_triggered
908+
@assertion_count = 2
909+
910+
pattern = Object.new
911+
def pattern.=~(other) true end
912+
def pattern.inspect; "<<Object>>" end
913+
914+
util_assert_triggered 'Expected <<Object>> to not match 5.' do
915+
@tc.refute_match pattern, 5
916+
end
917+
end
918+
869919
def test_refute_match_triggered
870920
@assertion_count = 2
871921
util_assert_triggered 'Expected /\w+/ to not match "blah blah blah".' do

0 commit comments

Comments
 (0)