* ext/openssl/ossl_ssl_session.c (ossl_ssl_session_initialize):

knu · knu · commit 061fd36d75bf · 2008-06-06T08:05:24.000Z
Add a null check for ssl; submitted by akira yamada
  in [ruby-dev:34950].

* ext/openssl/ossl_ssl.c (Init_ossl_ssl): Define OP_NO_TICKET if
  SSL_OP_NO_TICKET is present; submitted by akira yamada
  in [ruby-dev:34944].

* test/openssl/test_ssl.rb (OpenSSL#test_server_session): Add a
  workaround for the case where OpenSSL is configured with
  --enable-tlsext; submitted by akira yamada in [ruby-dev:34944].


git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_1_8_7@16857 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
diff --git a/ChangeLog b/ChangeLog
@@ -1,3 +1,17 @@
+Fri Jun  6 17:04:56 2008  Akinori MUSHA  <knu@iDaemons.org>
+
+	* ext/openssl/ossl_ssl_session.c (ossl_ssl_session_initialize):
+	  Add a null check for ssl; submitted by akira yamada
+	  in [ruby-dev:34950].
+
+	* ext/openssl/ossl_ssl.c (Init_ossl_ssl): Define OP_NO_TICKET if
+	  SSL_OP_NO_TICKET is present; submitted by akira yamada
+	  in [ruby-dev:34944].
+
+	* test/openssl/test_ssl.rb (OpenSSL#test_server_session): Add a
+	  workaround for the case where OpenSSL is configured with
+	  --enable-tlsext; submitted by akira yamada in [ruby-dev:34944].
+
 Fri Jun  6 16:58:23 2008  Nobuyoshi Nakada  <nobu@ruby-lang.org>
 
 	* ext/iconv/iconv.c (iconv_iconv): fix for length argument and now
diff --git a/ext/openssl/ossl_ssl.c b/ext/openssl/ossl_ssl.c
@@ -1466,6 +1466,9 @@ Init_ossl_ssl()
     ossl_ssl_def_const(OP_NO_SSLv2);
     ossl_ssl_def_const(OP_NO_SSLv3);
     ossl_ssl_def_const(OP_NO_TLSv1);
+#if defined(SSL_OP_NO_TICKET)
+    ossl_ssl_def_const(OP_NO_TICKET);
+#endif
     ossl_ssl_def_const(OP_PKCS1_CHECK_1);
     ossl_ssl_def_const(OP_PKCS1_CHECK_2);
     ossl_ssl_def_const(OP_NETSCAPE_CA_DN_BUG);
diff --git a/ext/openssl/ossl_ssl_session.c b/ext/openssl/ossl_ssl_session.c
@@ -47,7 +47,7 @@ static VALUE ossl_ssl_session_initialize(VALUE self, VALUE arg1)
 
 		Data_Get_Struct(arg1, SSL, ssl);
 
-		if ((ctx = SSL_get1_session(ssl)) == NULL)
+		if (!ssl || (ctx = SSL_get1_session(ssl)) == NULL)
 			ossl_raise(eSSLSession, "no session available");
 	} else {
 		BIO *in = ossl_obj2bio(arg1);
diff --git a/lib/cgi/session.rb b/lib/cgi/session.rb
@@ -230,7 +230,7 @@ def create_new_id
     # session_path:: the path for which this session applies.  Defaults
     #                to the directory of the CGI script.
     #
-    # +option+ is also passed on to the session storage class initialiser; see
+    # +option+ is also passed on to the session storage class initializer; see
     # the documentation for each session storage class for the options
     # they support.
     #                  
@@ -357,7 +357,7 @@ class FileStore
       # characters; automatically generated session ids observe
       # this requirement.
       # 
-      # +option+ is a hash of options for the initialiser.  The
+      # +option+ is a hash of options for the initializer.  The
       # following options are recognised:
       #
       # tmpdir:: the directory to use for storing the FileStore
diff --git a/lib/cgi/session/pstore.rb b/lib/cgi/session/pstore.rb
@@ -30,7 +30,7 @@ class PStore
       # characters; automatically generated session ids observe
       # this requirement.
       # 
-      # +option+ is a hash of options for the initialiser.  The
+      # +option+ is a hash of options for the initializer.  The
       # following options are recognised:
       #
       # tmpdir:: the directory to use for storing the PStore
diff --git a/lib/delegate.rb b/lib/delegate.rb
@@ -250,7 +250,7 @@ def dup
 # your class.
 #
 #   class MyClass < DelegateClass( ClassToDelegateTo )    # Step 1
-#     def initiaize
+#     def initialize
 #       super(obj_of_ClassToDelegateTo)                   # Step 2
 #     end
 #   end
diff --git a/lib/erb.rb b/lib/erb.rb
@@ -656,7 +656,7 @@ class ERB
   #    
   #    def build
   #      b = binding
-  #      # create and run templates, filling member data variebles
+  #      # create and run templates, filling member data variables
   #      ERB.new(<<-'END_PRODUCT'.gsub(/^\s+/, ""), 0, "", "@product").result b
   #        <%= PRODUCT[:name] %>
   #        <%= PRODUCT[:desc] %>
diff --git a/lib/forwardable.rb b/lib/forwardable.rb
@@ -38,7 +38,7 @@
 #       @q = [ ]    # prepare delegate object
 #     end
 #     
-#     # setup prefered interface, enq() and deq()...
+#     # setup preferred interface, enq() and deq()...
 #     def_delegator :@q, :push, :enq
 #     def_delegator :@q, :shift, :deq
 #     
diff --git a/lib/irb/extend-command.rb b/lib/irb/extend-command.rb
@@ -112,7 +112,7 @@ def self.install_extend_commands
       end
     end
 
-    # aliases = [commans_alias, flag], ...
+    # aliases = [commands_alias, flag], ...
     def self.def_extend_command(cmd_name, cmd_class, load_file = nil, *aliases)
       case cmd_class
       when Symbol
diff --git a/lib/irb/help.rb b/lib/irb/help.rb
@@ -1,5 +1,5 @@
 #
-#   irb/help.rb - print usase module
+#   irb/help.rb - print usage module
 #   	$Release Version: 0.9.5$
 #   	$Revision$
 #   	$Date$
diff --git a/lib/irb/notifier.rb b/lib/irb/notifier.rb
@@ -1,5 +1,5 @@
 #
-#   notifier.rb - optput methods used by irb 
+#   notifier.rb - output methods used by irb 
 #   	$Release Version: 0.9.5$
 #   	$Revision$
 #   	$Date$
diff --git a/lib/irb/ruby-lex.rb b/lib/irb/ruby-lex.rb
@@ -1,5 +1,5 @@
 #
-#   irb/ruby-lex.rb - ruby lexcal analizer
+#   irb/ruby-lex.rb - ruby lexcal analyzer
 #   	$Release Version: 0.9.5$
 #   	$Revision$
 #   	$Date$
diff --git a/lib/irb/slex.rb b/lib/irb/slex.rb
@@ -1,5 +1,5 @@
 #
-#   irb/slex.rb - symple lex analizer
+#   irb/slex.rb - simple lex analyzer
 #   	$Release Version: 0.9.5$
 #   	$Revision$
 #   	$Date$
diff --git a/lib/logger.rb b/lib/logger.rb
@@ -1,4 +1,4 @@
-# logger.rb - saimple logging utility
+# logger.rb - simple logging utility
 # Copyright (C) 2000-2003, 2005  NAKAMURA, Hiroshi <nakahiro@sarion.co.jp>.
 
 require 'monitor'
diff --git a/lib/net/https.rb b/lib/net/https.rb
@@ -65,11 +65,11 @@
 
 : key, key=((|key|))
     Sets an OpenSSL::PKey::RSA or OpenSSL::PKey::DSA object.
-    (This method is appeared in Michal Rokos's OpenSSL extention.)
+    (This method is appeared in Michal Rokos's OpenSSL extension.)
 
 : cert, cert=((|cert|))
     Sets an OpenSSL::X509::Certificate object as client certificate
-    (This method is appeared in Michal Rokos's OpenSSL extention).
+    (This method is appeared in Michal Rokos's OpenSSL extension).
 
 : ca_file, ca_file=((|path|))
     Sets path of a CA certification file in PEM format.
diff --git a/lib/optparse.rb b/lib/optparse.rb
@@ -826,7 +826,7 @@ def self.accept(*args, &blk) top.accept(*args, &blk) end
   #
   # Directs to reject specified class argument.
   #
-  # +t+:: Argument class speficier, any object including Class.
+  # +t+:: Argument class specifier, any object including Class.
   #
   #   reject(t)
   #
@@ -1037,13 +1037,13 @@ def notwice(obj, prv, msg)
   #     "-x[OPTIONAL]"
   #     "-x"
   #   There is also a special form which matches character range (not full
-  #   set of regural expression):
+  #   set of regular expression):
   #     "-[a-z]MANDATORY"
   #     "-[a-z][OPTIONAL]" 
   #     "-[a-z]"
   #
   # [Argument style and description:]
-  #   Instead of specifying mandatory or optional orguments directly in the
+  #   Instead of specifying mandatory or optional arguments directly in the
   #   switch parameter, this separate parameter can be used.
   #     "=MANDATORY"
   #     "=[OPTIONAL]"
diff --git a/lib/pstore.rb b/lib/pstore.rb
@@ -11,14 +11,14 @@
 require "digest/md5"
 
 #
-# PStore implements a file based persistance mechanism based on a Hash.  User
+# PStore implements a file based persistence mechanism based on a Hash.  User
 # code can store hierarchies of Ruby objects (values) into the data store file
 # by name (keys).  An object hierarchy may be just a single object.  User code 
 # may later read values back from the data store or even update data, as needed.
 # 
 # The transactional behavior ensures that any changes succeed or fail together.
 # This can be used to ensure that the data store is not left in a transitory
-# state, where some values were upated but others were not.
+# state, where some values were updated but others were not.
 # 
 # Behind the scenes, Ruby objects are stored to the data store file with 
 # Marshal.  That carries the usual limitations.  Proc objects cannot be 
diff --git a/lib/rdoc/parsers/parse_c.rb b/lib/rdoc/parsers/parse_c.rb
@@ -117,10 +117,10 @@ module RDoc
   # method in the HTML output. This method must be in the same source file
   # as the rb_define_method.
   #
-  # C classes can be diagramed (see /tc/dl/ruby/ruby/error.c), and RDoc
+  # C classes can be diagrammed (see /tc/dl/ruby/ruby/error.c), and RDoc
   # integrates C and Ruby source into one tree
   #
-  # The comment blocks may include special direcives:
+  # The comment blocks may include special directives:
   #
   # [Document-class: <i>name</i>]
   #   This comment block is documentation for the given class. Use this
@@ -131,10 +131,10 @@ module RDoc
   #   automatically find the method from it's declaration
   #
   # [call-seq:  <i>text up to an empty line</i>]
-  #   Because C source doesn't give descripive names to Ruby-level parameters,
+  #   Because C source doesn't give descriptive names to Ruby-level parameters,
   #   you need to document the calling sequence explicitly
   #
-  # In additon, RDoc assumes by default that the C method implementing a 
+  # In addition, RDoc assumes by default that the C method implementing a 
   # Ruby function is in the same source file as the rb_define_method call.
   # If this isn't the case, add the comment 
   #
diff --git a/lib/rdoc/parsers/parse_f95.rb b/lib/rdoc/parsers/parse_f95.rb
@@ -201,7 +201,7 @@ def initialize(top_level, file_name, body, options, stats)
       @progress = $stderr unless options.quiet
     end
 
-    # devine code constructs
+    # define code constructs
     def scan
 
       # remove private comment
@@ -1065,7 +1065,7 @@ def collect_first_comment(body)
     #
     # If "all" argument is true, information of all arguments are returned.
     # If "modified_params" is true, list of arguments are decorated,
-    # for exameple, optional arguments are parenthetic as "[arg]".
+    # for example, optional arguments are parenthetic as "[arg]".
     #
     def find_arguments(args, text, all=nil, indent=nil, modified_params=nil)
       return unless args || all
@@ -1143,8 +1143,8 @@ def find_namelists(text, before_contains=nil)
 
     #
     # Comments just after module or subprogram, or arguments are
-    # returnd. If "COMMENTS_ARE_UPPER" is true, comments just before
-    # modules or subprograms are returnd
+    # returned. If "COMMENTS_ARE_UPPER" is true, comments just before
+    # modules or subprograms are returned
     #
     def find_comments text
       return "" unless text
diff --git a/lib/resolv.rb b/lib/resolv.rb
@@ -252,7 +252,7 @@ def getnames(address)
     end
 
     ##
-    # Iterates over all hostnames for +address+ retrived from the hosts file.
+    # Iterates over all hostnames for +address+ retrieved from the hosts file.
 
     def each_name(address, &proc)
       lazy_initialize
@@ -2015,7 +2015,7 @@ def initialize(address) # :nodoc:
     end
 
     ##
-    # A String reperesentation of this IPv4 address.
+    # A String representation of this IPv4 address.
 
     ##
     # The raw IPv4 address as a String.
diff --git a/lib/rexml/attlistdecl.rb b/lib/rexml/attlistdecl.rb
@@ -44,7 +44,7 @@ def include?(key)
 			@pairs.keys.include? key
 		end
 
-		# Itterate over the key/value pairs:
+		# Iterate over the key/value pairs:
 		#  attlist_decl.each { |attribute_name, attribute_value| ... }
 		def each(&block)
 			@pairs.each(&block)
diff --git a/lib/rexml/document.rb b/lib/rexml/document.rb
@@ -147,7 +147,7 @@ def stand_alone?
     # A controversial point is whether Document should always write the XML
     # declaration (<?xml version='1.0'?>) whether or not one is given by the
     # user (or source document).  REXML does not write one if one was not
-    # specified, because it adds unneccessary bandwidth to applications such
+    # specified, because it adds unnecessary bandwidth to applications such
     # as XML-RPC.
     #
     # See also the classes in the rexml/formatters package for the proper way
diff --git a/lib/rexml/element.rb b/lib/rexml/element.rb
@@ -360,7 +360,7 @@ def each_element_with_attribute( key, value=nil, max=0, name=nil, &block ) # :yi
     # Iterates through the children, yielding for each Element that
     # has a particular text set.
     # text:: 
-    #   the text to search for.  If nil, or not supplied, will itterate
+    #   the text to search for.  If nil, or not supplied, will iterate
     #   over all +Element+ children that contain at least one +Text+ node.
     # max:: 
     #   (optional) causes this method to return after yielding
@@ -989,7 +989,7 @@ def length
     end
     alias :size :length
 
-    # Itterates over the attributes of an Element.  Yields actual Attribute
+    # Iterates over the attributes of an Element.  Yields actual Attribute
     # nodes, not String values.
     # 
     #  doc = Document.new '<a x="1" y="2"/>'
@@ -1006,7 +1006,7 @@ def each_attribute # :yields: attribute
       end
     end
 
-    # Itterates over each attribute of an Element, yielding the expanded name
+    # Iterates over each attribute of an Element, yielding the expanded name
     # and value as a pair of Strings.
     #
     #  doc = Document.new '<a x="1" y="2"/>'
diff --git a/lib/rexml/formatters/pretty.rb b/lib/rexml/formatters/pretty.rb
@@ -125,7 +125,7 @@ def indent_text(string, level=1, style="\t", indentfirstline=true)
       end
 
       def wrap(string, width)
-        # Recursivly wrap string at width.
+        # Recursively wrap string at width.
         return string if string.length <= width
         place = string.rindex(' ', width) # Position in string with last ' ' before cutoff
         return string[0,place] + "\n" + wrap(string[place+1..-1], width)
diff --git a/lib/rexml/functions.rb b/lib/rexml/functions.rb
@@ -235,7 +235,7 @@ def Functions::translate( string, tr1, tr2 )
       # from string then we ignore the second &
       # subsequent mappings
       #
-      # if a charactcer maps to nil then we delete it
+      # if a character maps to nil then we delete it
       # in the output.  This happens if the from
       # string is longer than the to string
       #
diff --git a/lib/rexml/text.rb b/lib/rexml/text.rb
@@ -189,7 +189,7 @@ def value=( val )
     end
  
      def wrap(string, width, addnewline=false)
-       # Recursivly wrap string at width.
+       # Recursively wrap string at width.
        return string if string.length <= width
        place = string.rindex(' ', width) # Position in string with last ' ' before cutoff
        if addnewline then
diff --git a/lib/rexml/xpath.rb b/lib/rexml/xpath.rb
@@ -30,7 +30,7 @@ def XPath::first element, path=nil, namespaces=nil, variables={}
 			parser.parse(path, element).flatten[0]
 		end
 
-		# Itterates over nodes that match the given path, calling the supplied
+		# Iterates over nodes that match the given path, calling the supplied
 		# block with the match.
 		# element::
 		#   The context element
diff --git a/lib/rinda/ring.rb b/lib/rinda/ring.rb
@@ -19,7 +19,7 @@ module Rinda
   # 1. A RingServer begins listening on the broadcast UDP address.
   # 2. A RingFinger sends a UDP packet containing the DRb URI where it will
   #    listen for a reply.
-  # 3. The RingServer recieves the UDP packet and connects back to the
+  # 3. The RingServer receives the UDP packet and connects back to the
   #    provided DRb URI with the DRb service.
 
   class RingServer
@@ -119,7 +119,7 @@ def self.primary
     end
 
     ##
-    # Contains all discoverd TupleSpaces except for the primary.
+    # Contains all discovered TupleSpaces except for the primary.
 
     def self.to_a
       finger.to_a
diff --git a/lib/time.rb b/lib/time.rb
@@ -363,7 +363,7 @@ def xmlschema(date)
         min = $5.to_i
         sec = $6.to_i
         usec = 0
-        usec = $7.to_f * 1000000 if $7
+        usec = ($7[1..-1] + '000000')[0,6].to_i if $7
         if $8
           zone = $8
           year, mon, day, hour, min, sec =
@@ -621,6 +621,8 @@ def test_encode_xmlschema
         t = Time.utc(1960, 12, 31, 23, 0, 0, 123456)
         assert_equal("1960-12-31T23:00:00.123456Z", t.xmlschema(6))
       end
+
+      assert_equal(249, Time.xmlschema("2008-06-05T23:49:23.000249+09:00").usec)
     end
 
     def test_completion
diff --git a/lib/webrick/httpproxy.rb b/lib/webrick/httpproxy.rb
@@ -47,7 +47,7 @@ def proxy_auth(req, res)
       req.header.delete("proxy-authorization")
     end
 
-    # Some header fields shuold not be transfered.
+    # Some header fields should not be transferred.
     HopByHop = %w( connection keep-alive proxy-authenticate upgrade
                    proxy-authorization te trailers transfer-encoding )
     ShouldNotTransfer = %w( set-cookie proxy-connection )
diff --git a/lib/webrick/httpresponse.rb b/lib/webrick/httpresponse.rb
@@ -132,7 +132,7 @@ def setup_header()
         end
       end
 
-      # Determin the message length (RFC2616 -- 4.4 Message Length)
+      # Determine the message length (RFC2616 -- 4.4 Message Length)
       if @status == 304 || @status == 204 || HTTPStatus::info?(@status)
         @header.delete('content-length')
         @body = ""
diff --git a/missing/vsnprintf.c b/missing/vsnprintf.c
diff --git a/object.c b/object.c
diff --git a/test/openssl/test_ssl.rb b/test/openssl/test_ssl.rb
diff --git a/version.h b/version.h
diff --git a/win32/win32.h b/win32/win32.h

Original file line number	Diff line number	Diff line change
`@@ -230,7 +230,7 @@ def create_new_id`
`230`	`230`	`# session_path:: the path for which this session applies. Defaults`
`231`	`231`	`# to the directory of the CGI script.`
`232`	`232`	`#`
`233`		`- # +option+ is also passed on to the session storage class initialiser; see`
	`233`	`+ # +option+ is also passed on to the session storage class initializer; see`
`234`	`234`	`# the documentation for each session storage class for the options`
`235`	`235`	`# they support.`
`236`	`236`	`#`
`@@ -357,7 +357,7 @@ class FileStore`
`357`	`357`	`# characters; automatically generated session ids observe`
`358`	`358`	`# this requirement.`
`359`	`359`	`#`
`360`		`- # +option+ is a hash of options for the initialiser. The`
	`360`	`+ # +option+ is a hash of options for the initializer. The`
`361`	`361`	`# following options are recognised:`
`362`	`362`	`#`
`363`	`363`	`# tmpdir:: the directory to use for storing the FileStore`
Original file line number	Diff line number	Diff line change
`@@ -30,7 +30,7 @@ class PStore`
`30`	`30`	`# characters; automatically generated session ids observe`
`31`	`31`	`# this requirement.`
`32`	`32`	`#`
`33`		`- # +option+ is a hash of options for the initialiser. The`
	`33`	`+ # +option+ is a hash of options for the initializer. The`
`34`	`34`	`# following options are recognised:`
`35`	`35`	`#`
`36`	`36`	`# tmpdir:: the directory to use for storing the PStore`
Original file line number	Diff line number	Diff line change
`@@ -250,7 +250,7 @@ def dup`
`250`	`250`	`# your class.`
`251`	`251`	`#`
`252`	`252`	`# class MyClass < DelegateClass( ClassToDelegateTo ) # Step 1`
`253`		`-# def initiaize`
	`253`	`+# def initialize`
`254`	`254`	`# super(obj_of_ClassToDelegateTo) # Step 2`
`255`	`255`	`# end`
`256`	`256`	`# end`
Original file line number	Diff line number	Diff line change
`@@ -656,7 +656,7 @@ class ERB`
`656`	`656`	`#`
`657`	`657`	`# def build`
`658`	`658`	`# b = binding`
`659`		`- # # create and run templates, filling member data variebles`
	`659`	`+ # # create and run templates, filling member data variables`
`660`	`660`	`# ERB.new(<<-'END_PRODUCT'.gsub(/^\s+/, ""), 0, "", "@product").result b`
`661`	`661`	`# <%= PRODUCT[:name] %>`
`662`	`662`	`# <%= PRODUCT[:desc] %>`
Original file line number	Diff line number	Diff line change
`@@ -38,7 +38,7 @@`
`38`	`38`	`# @q = [ ] # prepare delegate object`
`39`	`39`	`# end`
`40`	`40`	`#`
`41`		`-# # setup prefered interface, enq() and deq()...`
	`41`	`+# # setup preferred interface, enq() and deq()...`
`42`	`42`	`# def_delegator :@q, :push, :enq`
`43`	`43`	`# def_delegator :@q, :shift, :deq`
`44`	`44`	`#`
Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,5 @@`
`1`	`1`	`#`
`2`		`-# irb/help.rb - print usase module`
	`2`	`+# irb/help.rb - print usage module`
`3`	`3`	`# $Release Version: 0.9.5$`
`4`	`4`	`# $Revision$`
`5`	`5`	`# $Date$`