Fix bogus use of "long" in AllocSetCheck()
authorDavid Rowley <drowley@postgresql.org>
Thu, 30 Oct 2025 01:48:10 +0000 (14:48 +1300)
committerDavid Rowley <drowley@postgresql.org>
Thu, 30 Oct 2025 01:48:10 +0000 (14:48 +1300)
commit50eb4e11815664bfcee883e92f4bf238ac23ec12
treeedc2157fdc4c7cdf8783b021da463c139473dc08
parent3853a6956c3e3bc7a6fa9bcdb205a2997f46bac2
Fix bogus use of "long" in AllocSetCheck()

Because long is 32-bit on 64-bit Windows, it isn't a good datatype to
store the difference between 2 pointers.  The under-sized type could
overflow and lead to scary warnings in MEMORY_CONTEXT_CHECKING builds,
such as:

WARNING:  problem in alloc set ExecutorState: bad single-chunk %p in block %p

However, the problem lies only in the code running the check, not from
an actual memory accounting bug.

Fix by using "Size" instead of "long".  This means using an unsigned
type rather than the previous signed type.  If the block's freeptr was
corrupted, we'd still catch that if the unsigned type wrapped.  Unsigned
allows us to avoid further needless complexities around comparing signed
and unsigned types.

Author: David Rowley <dgrowleyml@gmail.com>
Reviewed-by: Michael Paquier <michael@paquier.xyz>
Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us>
Backpatch-through: 13
Discussion: https://postgr.es/m/CAApHDvo-RmiT4s33J=aC9C_-wPZjOXQ232V-EZFgKftSsNRi4w@mail.gmail.com
src/backend/utils/mmgr/aset.c