Remove entry tree root conflict checking from GIN predicate locking
authorAlexander Korotkov <akorotkov@postgresql.org>
Thu, 27 Dec 2018 01:10:51 +0000 (04:10 +0300)
committerAlexander Korotkov <akorotkov@postgresql.org>
Thu, 27 Dec 2018 01:24:20 +0000 (04:24 +0300)
commitb450abd2551ee30b5bc289c662f5728d87e13a39
tree6d4f6671df05664ade51c6174d80cb23b6c57964
parent1e504f01da11db0181d7b28bb30cb5eeb0767184
Remove entry tree root conflict checking from GIN predicate locking

According to README we acquire predicate locks on entry tree leafs and posting
tree roots.  However, when ginFindLeafPage() is going to lock leaf in exclusive
mode, then it checks root for conflicts regardless whether it's a entry or
posting tree.  Assuming that we never place predicate lock on entry tree root
(excluding corner case when root is leaf), this check is redundant.  This
commit removes this check.  Now, root conflict checking is controlled by
separate argument of ginFindLeafPage().

Discussion: https://postgr.es/m/CAPpHfdv7rrDyy%3DMgsaK-L9kk0AH7az0B-mdC3w3p0FSb9uoyEg%40mail.gmail.com
Author: Alexander Korotkov
Backpatch-through: 11
src/backend/access/gin/ginbtree.c
src/backend/access/gin/gindatapage.c
src/backend/access/gin/ginget.c
src/backend/access/gin/gininsert.c
src/include/access/gin_private.h