projects / users / bernd / postgres.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: 4ae7f02) | patch
Catch syntax error in generated column definition
authorPeter Eisentraut <peter@eisentraut.org>
Mon, 1 Apr 2019 08:46:37 +0000 (10:46 +0200)
committerPeter Eisentraut <peter@eisentraut.org>
Mon, 1 Apr 2019 08:46:37 +0000 (10:46 +0200)
commit7241911782a7420e38b6e50b57d304ea48bc5362
tree687e642d5b3256ab24d35cb4d16f86002c6f1df9tree
parent4ae7f02b0364ccba49a82efbfff46125fb357d6ccommit | diff
Catch syntax error in generated column definition

The syntax

    GENERATED BY DEFAULT AS (expr)

is not allowed but we have to accept it in the grammar to avoid
shift/reduce conflicts because of the similar syntax for identity
columns.  The existing code just ignored this, incorrectly.  Add an
explicit error check and a bespoke error message.

Reported-by: Justin Pryzby <pryzby@telsasoft.com>
src/backend/parser/gram.y diff | blob | blame | history
src/test/regress/expected/generated.out diff | blob | blame | history
src/test/regress/sql/generated.sql diff | blob | blame | history
Bernd Helmle's repository