From 9b69c68adfbd3ac0a59a5bfb99ee9b69affdecde Mon Sep 17 00:00:00 2001 From: Alvaro Herrera Date: Sun, 8 Mar 2009 16:07:12 +0000 Subject: [PATCH] On Windows, call bind_textdomain_codeset on domains other than the default one, too, so that the codeset is properly mapped on the newly added PL domains. --- src/backend/utils/init/miscinit.c | 2 ++ src/backend/utils/mb/mbutils.c | 31 ++++++++++++++++++------------- src/include/mb/pg_wchar.h | 1 + 3 files changed, 21 insertions(+), 13 deletions(-) diff --git a/src/backend/utils/init/miscinit.c b/src/backend/utils/init/miscinit.c index 926552b1f8..03d86ca5f9 100644 --- a/src/backend/utils/init/miscinit.c +++ b/src/backend/utils/init/miscinit.c @@ -30,6 +30,7 @@ #endif #include "catalog/pg_authid.h" +#include "mb/pg_wchar.h" #include "miscadmin.h" #include "postmaster/autovacuum.h" #include "storage/fd.h" @@ -1241,6 +1242,7 @@ pg_bindtextdomain(const char *domain) get_locale_path(my_exec_path, locale_path); bindtextdomain(domain, locale_path); + pg_bind_textdomain_codeset(domain, GetDatabaseEncoding()); } #endif } diff --git a/src/backend/utils/mb/mbutils.c b/src/backend/utils/mb/mbutils.c index 2c343f9d06..e8b1d7c94c 100644 --- a/src/backend/utils/mb/mbutils.c +++ b/src/backend/utils/mb/mbutils.c @@ -891,22 +891,27 @@ SetDatabaseEncoding(int encoding) DatabaseEncoding = &pg_enc2name_tbl[encoding]; Assert(DatabaseEncoding->encoding == encoding); - /* - * On Windows, we need to explicitly bind gettext to the correct - * encoding, because gettext() tends to get confused. - */ + pg_bind_textdomain_codeset(textdomain(NULL), encoding); +} + +/* + * On Windows, we need to explicitly bind gettext to the correct + * encoding, because gettext() tends to get confused. + */ +void +pg_bind_textdomain_codeset(const char *domainname, int encoding) +{ #if defined(ENABLE_NLS) && defined(WIN32) - { - int i; + int i; - for (i = 0; i < sizeof(codeset_map_array) / sizeof(codeset_map_array[0]); i++) + for (i = 0; i < lengthof(codeset_map_array); i++) + { + if (codeset_map_array[i].encoding == encoding) { - if (codeset_map_array[i].encoding == encoding) - { - if (bind_textdomain_codeset(textdomain(NULL), codeset_map_array[i].codeset) == NULL) - elog(LOG, "bind_textdomain_codeset failed"); - break; - } + if (bind_textdomain_codeset(domainname, + codeset_map_array[i].codeset) == NULL) + elog(LOG, "bind_textdomain_codeset failed"); + break; } } #endif diff --git a/src/include/mb/pg_wchar.h b/src/include/mb/pg_wchar.h index 4ebeda5c1f..76322c9e36 100644 --- a/src/include/mb/pg_wchar.h +++ b/src/include/mb/pg_wchar.h @@ -392,6 +392,7 @@ extern const char *pg_get_client_encoding_name(void); extern void SetDatabaseEncoding(int encoding); extern int GetDatabaseEncoding(void); extern const char *GetDatabaseEncodingName(void); +extern void pg_bind_textdomain_codeset(const char *domainname, int encoding); extern int pg_valid_client_encoding(const char *name); extern int pg_valid_server_encoding(const char *name); -- 2.39.5