users/rhaas/postgres.git
12 years agoAdjust 9.3 release notes per request from Simon
Bruce Momjian [Sun, 21 Apr 2013 13:05:16 +0000 (09:05 -0400)]
Adjust 9.3 release notes per request from Simon

12 years agoReorder 9.3 release note items
Bruce Momjian [Sun, 21 Apr 2013 04:57:18 +0000 (00:57 -0400)]
Reorder 9.3 release note items

Typo fix from David Fetter.

12 years agoMore 9.3 release note reorderings
Bruce Momjian [Sat, 20 Apr 2013 21:31:06 +0000 (17:31 -0400)]
More 9.3 release note reorderings

12 years agoFix Gilles Darold's name in 9.3 release notes.
Bruce Momjian [Sat, 20 Apr 2013 21:09:10 +0000 (17:09 -0400)]
Fix Gilles Darold's name in 9.3 release notes.

12 years agoFix longstanding race condition in plancache.c.
Tom Lane [Sat, 20 Apr 2013 20:59:21 +0000 (16:59 -0400)]
Fix longstanding race condition in plancache.c.

When creating or manipulating a cached plan for a transaction control
command (particularly ROLLBACK), we must not perform any catalog accesses,
since we might be in an aborted transaction.  However, plancache.c busily
saved or examined the search_path for every cached plan.  If we were
unlucky enough to do this at a moment where the path's expansion into
schema OIDs wasn't already cached, we'd do some catalog accesses; and with
some more bad luck such as an ill-timed signal arrival, that could lead to
crashes or Assert failures, as exhibited in bug #8095 from Nachiket Vaidya.
Fortunately, there's no real need to consider the search path for such
commands, so we can just skip the relevant steps when the subject statement
is a TransactionStmt.  This is somewhat related to bug #5269, though the
failure happens during initial cached-plan creation rather than
revalidation.

This bug has been there since the plan cache was invented, so back-patch
to all supported branches.

12 years agoReorder some 9.3 release item entries
Bruce Momjian [Sat, 20 Apr 2013 20:50:56 +0000 (16:50 -0400)]
Reorder some 9.3 release item entries

More to go.

12 years agoPush 9.3 release SGML file
Bruce Momjian [Sat, 20 Apr 2013 20:32:32 +0000 (16:32 -0400)]
Push 9.3 release SGML file

Forgotten in previous commit.

12 years agoPublish draft 9.3 release notes
Bruce Momjian [Sat, 20 Apr 2013 20:29:58 +0000 (16:29 -0400)]
Publish draft 9.3 release notes

No links added yet.

12 years agodoc: Mention SATA alongside IDE for Linux
Peter Eisentraut [Sat, 20 Apr 2013 19:56:22 +0000 (15:56 -0400)]
doc: Mention SATA alongside IDE for Linux

suggested by Jov

12 years agoClean up references to SQL92
Peter Eisentraut [Sat, 20 Apr 2013 15:04:41 +0000 (11:04 -0400)]
Clean up references to SQL92

In most cases, these were just references to the SQL standard in
general.  In a few cases, a contrast was made between SQL92 and later
standards -- those have been kept unchanged.

12 years agoImprove error message when an FDW doesn't support WHERE CURRENT OF.
Tom Lane [Fri, 19 Apr 2013 20:14:56 +0000 (16:14 -0400)]
Improve error message when an FDW doesn't support WHERE CURRENT OF.

If an FDW fails to take special measures with a CurrentOfExpr, we will
end up trying to execute it as an ordinary qual, which was being treated
as a purely internal failure condition.  Provide a more user-oriented
error message for such cases.

12 years agoDon't try to pass -I switch to postmaster in contrib/start-scripts/linux.
Tom Lane [Fri, 19 Apr 2013 17:28:45 +0000 (13:28 -0400)]
Don't try to pass -I switch to postmaster in contrib/start-scripts/linux.

Undo thinko in commit 87306184580c9c49717b00d48a2f9e717f21e0a8.
Per bug #8098 from Catherine Devlin.

12 years agoFix typo in comment.
Robert Haas [Fri, 19 Apr 2013 13:32:49 +0000 (09:32 -0400)]
Fix typo in comment.

Fabrízio de Royes Mello

12 years agoStandardize spelling of "nonblocking"
Peter Eisentraut [Fri, 19 Apr 2013 03:35:19 +0000 (23:35 -0400)]
Standardize spelling of "nonblocking"

Only adjusted the user-exposed messages and documentation,  not all
source code comments.

12 years agopg_upgrade: Add checksum C comment
Bruce Momjian [Wed, 17 Apr 2013 21:39:14 +0000 (17:39 -0400)]
pg_upgrade:  Add checksum C comment

We might eventually allow checksum to no-checksum upgrades.

12 years agosepgsql: Minor improvement to test script, doc fix.
Robert Haas [Wed, 17 Apr 2013 13:55:24 +0000 (09:55 -0400)]
sepgsql: Minor improvement to test script, doc fix.

KaiGai Kohei

12 years agosepgsql: One more getObjectIdentity in lieu of getObjectDescription.
Robert Haas [Wed, 17 Apr 2013 13:52:25 +0000 (09:52 -0400)]
sepgsql: One more getObjectIdentity in lieu of getObjectDescription.

KaiGai Kohei, based on a suggestion from Álvaro Herrera

12 years agodoc: Update PQgetssl() documentation
Peter Eisentraut [Wed, 17 Apr 2013 01:42:10 +0000 (21:42 -0400)]
doc: Update PQgetssl() documentation

The return type of PQgetssl() was changed from SSL* to void* a long time
ago, but the documentation was not updated.

12 years agopgindent: add newline to die() so script line number is not reported on failure.
Bruce Momjian [Tue, 16 Apr 2013 14:30:31 +0000 (10:30 -0400)]
pgindent:  add newline to die() so script line number is not reported on failure.

12 years agoRemove some unused and seldom used fields from RelationAmInfo.
Heikki Linnakangas [Tue, 16 Apr 2013 12:01:21 +0000 (15:01 +0300)]
Remove some unused and seldom used fields from RelationAmInfo.

This saves some memory from each index relcache entry. At least on a 64-bit
machine, it saves just enough to shrink a typical relcache entry's memory
usage from 2k to 1k. That's nice if you have a lot of backends and a lot of
indexes.

12 years agoFix function return type confusion
Peter Eisentraut [Tue, 16 Apr 2013 02:33:24 +0000 (22:33 -0400)]
Fix function return type confusion

When parse_hba_line's return type was changed from bool to a pointer,
the MANDATORY_AUTH_ARG macro wasn't adjusted.

12 years agoMark json IO and extraction functions immutable.
Andrew Dunstan [Tue, 16 Apr 2013 01:46:25 +0000 (21:46 -0400)]
Mark json IO and extraction functions immutable.

Per complaint from Hubert Depesz Lubaczewski.

Catalog version bumped.

12 years agoCorrect handling of NULL arguments in json funcs.
Andrew Dunstan [Mon, 15 Apr 2013 20:20:21 +0000 (16:20 -0400)]
Correct handling of NULL arguments in json funcs.

Per gripe from Tom Lane.

12 years agoImprove GiST index search performance for trigram regex queries.
Tom Lane [Mon, 15 Apr 2013 16:49:29 +0000 (12:49 -0400)]
Improve GiST index search performance for trigram regex queries.

The initial coding just descended the index if any of the target trigrams
were possibly present at the next level down.  But actually we can apply
trigramsMatchGraph() so as to take advantage of AND requirements when there
are some.  The input data might contain false positive matches, but that
can only result in a false positive result, not false negative, so it's
safe to do it this way.

Alexander Korotkov

12 years agoAdd serial comma
Peter Eisentraut [Sun, 14 Apr 2013 15:12:30 +0000 (11:12 -0400)]
Add serial comma

12 years agopg_ctl: Add idempotent option
Peter Eisentraut [Sun, 14 Apr 2013 03:42:42 +0000 (23:42 -0400)]
pg_ctl: Add idempotent option

This changes the behavior of the start and stop actions to exit
successfully if the server was already started or stopped.

This changes the default behavior of the start action:  Before, if the
server was already running, it would print a message and succeed.  Now,
that situation will result in an error.  When running in idempotent
mode, no message is printed and pg_ctl exits successfully.

It was considered to just make the idempotent behavior the default and
only option, but pg_upgrade needs the old behavior.

12 years agoFix sporadic rebuilds for .pc files
Peter Eisentraut [Sat, 13 Apr 2013 02:45:51 +0000 (22:45 -0400)]
Fix sporadic rebuilds for .pc files

The build of .pc (pkg-config) files depends on all makefiles in use, and
in dependency tracking mode, the previous coding ended up including
/dev/null as a makefile.  Apparently, on some platforms the modification
time of /dev/null changes sporadically, and so the .pc files would end
up being rebuilt every so often.  Fix that by changing the makefile code
to do without using /dev/null.

12 years agoClean up the mess around EXPLAIN and materialized views.
Tom Lane [Fri, 12 Apr 2013 23:25:20 +0000 (19:25 -0400)]
Clean up the mess around EXPLAIN and materialized views.

Revert the matview-related changes in explain.c's API, as per recent
complaint from Robert Haas.  The reason for these appears to have been
principally some ill-considered choices around having intorel_startup do
what ought to be parse-time checking, plus a poor arrangement for passing
it the view parsetree it needs to store into pg_rewrite when creating a
materialized view.  Do the latter by having parse analysis stick a copy
into the IntoClause, instead of doing it at runtime.  (On the whole,
I seriously question the choice to represent CREATE MATERIALIZED VIEW as a
variant of SELECT INTO/CREATE TABLE AS, because that means injecting even
more complexity into what was already a horrid legacy kluge.  However,
I didn't go so far as to rethink that choice ... yet.)

I also moved several error checks into matview parse analysis, and
made the check for external Params in a matview more accurate.

In passing, clean things up a bit more around interpretOidsOption(),
and fix things so that we can use that to force no-oids for views,
sequences, etc, thereby eliminating the need to cons up "oids = false"
options when creating them.

catversion bump due to change in IntoClause.  (I wonder though if we
really need readfuncs/outfuncs support for IntoClause anymore.)

12 years agopgindent: improve error messages
Bruce Momjian [Fri, 12 Apr 2013 19:25:33 +0000 (15:25 -0400)]
pgindent: improve error messages

per suggestion from Gurjeet Singh

12 years agopgindent: fix downloading of BSD indent binary
Bruce Momjian [Fri, 12 Apr 2013 15:42:27 +0000 (11:42 -0400)]
pgindent:  fix downloading of BSD indent binary

Also fix accessing pgentab binary and tar.

Gurjeet Singh

12 years agosepgsql: Enforce db_procedure:{execute} permission.
Robert Haas [Fri, 12 Apr 2013 12:55:56 +0000 (08:55 -0400)]
sepgsql: Enforce db_procedure:{execute} permission.

To do this, we add an additional object access hook type,
OAT_FUNCTION_EXECUTE.

KaiGai Kohei

12 years agoMinor wording corrections for object-access hook stuff.
Robert Haas [Fri, 12 Apr 2013 12:39:38 +0000 (08:39 -0400)]
Minor wording corrections for object-access hook stuff.

KaiGai Kohei

12 years agosepgql: Use getObjectIdentity rather than getObjectDescription.
Robert Haas [Fri, 12 Apr 2013 12:35:55 +0000 (08:35 -0400)]
sepgql: Use getObjectIdentity rather than getObjectDescription.

KaiGai Kohei, based on a suggestion from Álvaro Herrera

12 years agoDocument that git_changelog needs updating for major version stamping.
Bruce Momjian [Thu, 11 Apr 2013 16:27:02 +0000 (12:27 -0400)]
Document that git_changelog needs updating for major version stamping.

12 years agoRemove quotes around SQL statement in error message
Alvaro Herrera [Thu, 11 Apr 2013 15:00:09 +0000 (12:00 -0300)]
Remove quotes around SQL statement in error message

12 years agoFix confusion between ObjectType and ObjectClass
Alvaro Herrera [Thu, 11 Apr 2013 14:59:47 +0000 (11:59 -0300)]
Fix confusion between ObjectType and ObjectClass

Per report by Will Leinweber and Peter Eisentraut

12 years agodoc: Update DTrace information
Peter Eisentraut [Thu, 11 Apr 2013 03:05:13 +0000 (23:05 -0400)]
doc: Update DTrace information

The old web site link no longer worked, and some information was
outdated.

12 years agoUpdate the description for the graphical installers
Magnus Hagander [Wed, 10 Apr 2013 19:37:49 +0000 (21:37 +0200)]
Update the description for the graphical installers

Remove references to "one click", as we're not supposed to call
them that anymore.

12 years agoFix SIGUSR1 handling by unconnected bgworkers
Alvaro Herrera [Wed, 10 Apr 2013 19:01:16 +0000 (16:01 -0300)]
Fix SIGUSR1 handling by unconnected bgworkers

Latch activity was not being detected by non-database-connected workers; the
SIGUSR1 signal handler which is normally in charge of that was set to SIG_IGN.
Create a simple handler to call latch_sigusr1_handler instead.

Robert Haas (bug report and suggested fix)

12 years agoFix SIGHUP handling by unconnected bgworkers
Alvaro Herrera [Wed, 10 Apr 2013 18:59:45 +0000 (15:59 -0300)]
Fix SIGHUP handling by unconnected bgworkers

Add a SignalUnconnectedWorkers() call so that non-database-connected background
workers are also notified when postmaster is SIGHUPped.  Previously, only
database-connected workers were.

Michael Paquier (bug report and&nb