Fix memory leak pointed out by Coverity.
authorMasaya Kawamoto <kawamoto@sraoss.co.jp>
Mon, 11 Apr 2022 07:20:58 +0000 (07:20 +0000)
committerMasaya Kawamoto <kawamoto@sraoss.co.jp>
Mon, 11 Apr 2022 07:20:58 +0000 (07:20 +0000)
src/auth/pool_passwd.c

index fb4ee3528399e3bbe98e89e0857f5f957bbafe6b..5d93e54b652d6178235560928b8d83470a7dd482 100644 (file)
@@ -705,7 +705,6 @@ int
 chceck_password_type_is_not_md5(char *username, char *password_in_config)
 {
        PasswordType passwordType = PASSWORD_TYPE_UNKNOWN;
-       PasswordMapping *password_mapping = NULL;
 
        /*
         * if the password specified in config is empty string or NULL look for the
@@ -713,12 +712,14 @@ chceck_password_type_is_not_md5(char *username, char *password_in_config)
         */
        if (password_in_config == NULL || strlen(password_in_config) == 0)
        {
+               PasswordMapping *password_mapping = NULL;
                password_mapping = pool_get_user_credentials(username);
                if (password_mapping == NULL)
                {
                        return -2;
                }
                passwordType = password_mapping->pgpoolUser.passwordType;
+               delete_passwordMapping(password_mapping);
        }
        else
        {