git.postgresql.org Git - users/simon/postgres.git/commit

projects / users / simon / postgres.git / commit

summary | shortlog | log | commit | commitdiff | tree
(parent: bb18fee) | patch

author	Tom Lane <tgl@sss.pgh.pa.us>
	Mon, 6 Oct 2008 17:39:26 +0000 (17:39 +0000)
committer	Tom Lane <tgl@sss.pgh.pa.us>
	Mon, 6 Oct 2008 17:39:26 +0000 (17:39 +0000)
commit	c0a1b283e78221a2486f3c6fc072c055b1ba53d6
tree	20de76f4ab062355ad6721aea03027a1cd1d6fd8	tree
parent	bb18feef1034e76e9a94822a1d3ea1974808dbc3	commit \| diff

When expanding a whole-row Var into a RowExpr during ResolveNew(), attach
the column alias names of the RTE referenced by the Var to the RowExpr.
This is needed to allow ruleutils.c to correctly deparse FieldSelect nodes
referencing such a construct. Per my recent bug report.

Adding a field to RowExpr forces initdb (because of stored rules changes)
so this solution is not back-patchable; which is unfortunate because 8.2
and 8.3 have this issue. But it only affects EXPLAIN for some pretty odd
corner cases, so we can probably live without a solution for the back
branches.

13 files changed:

src/backend/nodes/copyfuncs.c		diff \| blob \| blame \| history
src/backend/nodes/equalfuncs.c		diff \| blob \| blame \| history
src/backend/nodes/nodeFuncs.c		diff \| blob \| blame \| history
src/backend/nodes/outfuncs.c		diff \| blob \| blame \| history
src/backend/nodes/readfuncs.c		diff \| blob \| blame \| history
src/backend/optimizer/prep/prepunion.c		diff \| blob \| blame \| history
src/backend/optimizer/util/var.c		diff \| blob \| blame \| history
src/backend/parser/parse_coerce.c		diff \| blob \| blame \| history
src/backend/parser/parse_expr.c		diff \| blob \| blame \| history
src/backend/rewrite/rewriteManip.c		diff \| blob \| blame \| history
src/backend/utils/adt/ruleutils.c		diff \| blob \| blame \| history
src/include/catalog/catversion.h		diff \| blob \| blame \| history
src/include/nodes/primnodes.h		diff \| blob \| blame \| history

Simon's dev repository