Remove useless casting to same type
authorPeter Eisentraut <peter@eisentraut.org>
Tue, 2 Dec 2025 09:05:12 +0000 (10:05 +0100)
committerPeter Eisentraut <peter@eisentraut.org>
Tue, 2 Dec 2025 09:09:32 +0000 (10:09 +0100)
commit4f941d432b42eccd99ba0d22e3a59c073ac2406a
tree0d9b07faff2842d0fe07a39d761b2fd0ac99ab89
parent35988b31db7767ba446009611b9928add1d40f98
Remove useless casting to same type

This removes some casts where the input already has the same type as
the type specified by the cast.  Their presence could cause risks of
hiding actual type mismatches in the future or silently discarding
qualifiers.  It also improves readability.  Same kind of idea as
7f798aca1d5 and ef8fe693606.  (This does not change all such
instances, but only those hand-picked by the author.)

Author: Bertrand Drouvot <bertranddrouvot.pg@gmail.com>
Reviewed-by: Nathan Bossart <nathandbossart@gmail.com>
Reviewed-by: Jacob Champion <jacob.champion@enterprisedb.com>
Reviewed-by: Peter Eisentraut <peter@eisentraut.org>
Discussion: https://www.postgresql.org/message-id/flat/aSQy2JawavlVlEB0%40ip-10-97-1-34.eu-west-3.compute.internal
41 files changed:
contrib/btree_gist/btree_utils_num.c
contrib/cube/cube.c
contrib/fuzzystrmatch/dmetaphone.c
contrib/pgcrypto/mbuf.c
src/backend/access/common/indextuple.c
src/backend/access/gin/gindatapage.c
src/backend/access/gin/gininsert.c
src/backend/access/hash/hash_xlog.c
src/backend/access/transam/twophase.c
src/backend/catalog/aclchk.c
src/backend/commands/tablecmds.c
src/backend/executor/execExpr.c
src/backend/executor/execExprInterp.c
src/backend/executor/execPartition.c
src/backend/executor/nodeTableFuncscan.c
src/backend/optimizer/geqo/geqo_pool.c
src/backend/optimizer/plan/planner.c
src/backend/optimizer/util/pathnode.c
src/backend/parser/analyze.c
src/backend/parser/parse_expr.c
src/backend/port/sysv_shmem.c
src/backend/replication/walsender.c
src/backend/rewrite/rewriteHandler.c
src/backend/statistics/dependencies.c
src/backend/statistics/extended_stats.c
src/backend/statistics/mcv.c
src/backend/storage/aio/aio.c
src/backend/storage/aio/method_io_uring.c
src/backend/storage/ipc/waiteventset.c
src/backend/storage/lmgr/predicate.c
src/backend/storage/lmgr/proc.c
src/backend/utils/adt/arrayfuncs.c
src/backend/utils/adt/jsonfuncs.c
src/backend/utils/adt/ruleutils.c
src/bin/pg_dump/pg_dump.c
src/common/sha1.c
src/interfaces/ecpg/ecpglib/descriptor.c
src/interfaces/ecpg/ecpglib/execute.c
src/interfaces/ecpg/ecpglib/prepare.c
src/port/win32ntdll.c
src/test/modules/test_radixtree/test_radixtree.c