rework for scans
authorRobert Haas <rhaas@postgresql.org>
Wed, 16 Jul 2025 17:01:53 +0000 (13:01 -0400)
committerRobert Haas <rhaas@postgresql.org>
Wed, 16 Jul 2025 17:01:53 +0000 (13:01 -0400)
commit4068a98d1993ed1cc8443f7b57fd8cb54cb4436c
treeb0105ff3155b4b5a960ec802c5f682f69221c12f
parentfbaa10ea9ca8ba29c748afbd9e7547d7bc5c9a28
rework for scans

This seems to actually kind of work, but there are definitely some things
that are broken.

In particular, PARTITIONWISE() advice is being emitted for plans where
Append nodes are induced by setops rather than by table inheritance;
and what looks like extra PARTITIONWISE() advice is also being emitted
for non-obvious reasons in some table inheritance cases.

Also, INDEX_SCAN(), INDEX_ONLY_SCAN(), and BITMAP_HEAP_SCAN() output
needs revising, and ORDINARY_SCAN() output needs suppressing.
contrib/pg_plan_advice/pgpa_join.c
contrib/pg_plan_advice/pgpa_join.h
contrib/pg_plan_advice/pgpa_output.c
contrib/pg_plan_advice/pgpa_scan.c
contrib/pg_plan_advice/pgpa_scan.h
contrib/pg_plan_advice/pgpa_walker.c