amcheck: Fix snapshot usage in bt_index_parent_check master github/master
authorÁlvaro Herrera <alvherre@kurilemu.de>
Thu, 4 Dec 2025 17:12:08 +0000 (18:12 +0100)
committerÁlvaro Herrera <alvherre@kurilemu.de>
Thu, 4 Dec 2025 17:12:08 +0000 (18:12 +0100)
commit6bd469d26aca6ea413b35bfcb611dfa3a8f5ea45
tree6c51ccb7362155e0ea0c6ea0a03d6c9ce9db17cf
parent40bdd839f52a3e18a0e003f556cab3512510f633
amcheck: Fix snapshot usage in bt_index_parent_check

We were using SnapshotAny to do some index checks, but that's wrong and
causes spurious errors when used on indexes created by CREATE INDEX
CONCURRENTLY.  Fix it to use an MVCC snapshot, and add a test for it.

This problem came in with commit 5ae2087202af, which introduced
uniqueness check.  Backpatch to 17.

Author: Mihail Nikalayeu <mihailnikalayeu@gmail.com>
Reviewed-by: Andrey Borodin <x4mmm@yandex-team.ru>
Backpatch-through: 17
Discussion: https://postgr.es/m/CANtu0ojmVd27fEhfpST7RG2KZvwkX=dMyKUqg0KM87FkOSdz8Q@mail.gmail.com
contrib/amcheck/t/002_cic.pl
contrib/amcheck/verify_nbtree.c
doc/src/sgml/amcheck.sgml