Remove TypeName struct's timezone flag, which has been write-only storage

for a very long time --- in current usage it's entirely redundant with the
name field.

diff --git a/src/backend/nodes/copyfuncs.c b/src/backend/nodes/copyfuncs.c
index 7b1bed08a0255284e59cb5f109238f359db1d2ab..77bba77a62d8dace253c75297312bd83e67667d9 100644 (file)
--- a/src/backend/nodes/copyfuncs.c
+++ b/src/backend/nodes/copyfuncs.c
@@ -1714,7 +1714,6 @@ _copyTypeName(TypeName *from)
 
        COPY_NODE_FIELD(names);
        COPY_SCALAR_FIELD(typeid);
-       COPY_SCALAR_FIELD(timezone);
        COPY_SCALAR_FIELD(setof);
        COPY_SCALAR_FIELD(pct_type);
        COPY_NODE_FIELD(typmods);

diff --git a/src/backend/nodes/equalfuncs.c b/src/backend/nodes/equalfuncs.c
index 3be189206fd92ee9caf9bedfe44ef395d74ced0f..7645e45eb18d41d3eb2d46a5f3f892f329437561 100644 (file)
--- a/src/backend/nodes/equalfuncs.c
+++ b/src/backend/nodes/equalfuncs.c
@@ -1753,7 +1753,6 @@ _equalTypeName(TypeName *a, TypeName *b)
 {
        COMPARE_NODE_FIELD(names);
        COMPARE_SCALAR_FIELD(typeid);
-       COMPARE_SCALAR_FIELD(timezone);
        COMPARE_SCALAR_FIELD(setof);
        COMPARE_SCALAR_FIELD(pct_type);
        COMPARE_NODE_FIELD(typmods);

diff --git a/src/backend/nodes/outfuncs.c b/src/backend/nodes/outfuncs.c
index 136da9f459d061c56cf05ffb6222b25291c49834..72ee2ff25dc4c591c07d40590c714d725f94e808 100644 (file)
--- a/src/backend/nodes/outfuncs.c
+++ b/src/backend/nodes/outfuncs.c
@@ -1668,7 +1668,6 @@ _outTypeName(StringInfo str, TypeName *node)
 
        WRITE_NODE_FIELD(names);
        WRITE_OID_FIELD(typeid);
-       WRITE_BOOL_FIELD(timezone);
        WRITE_BOOL_FIELD(setof);
        WRITE_BOOL_FIELD(pct_type);
        WRITE_NODE_FIELD(typmods);

diff --git a/src/backend/parser/gram.y b/src/backend/parser/gram.y
index 9a56ec689cc2b0330442243df035faa5deb0a455..bcf2efc88fa85ab2aa8a27b492f1dce78790db20 100644 (file)
--- a/src/backend/parser/gram.y
+++ b/src/backend/parser/gram.y
@@ -7198,10 +7198,6 @@ ConstDatetime:
                                                $$ = SystemTypeName("timestamptz");
                                        else
                                                $$ = SystemTypeName("timestamp");
-                                       /* XXX the timezone field seems to be unused
-                                        * - thomas 2001-09-06
-                                        */
-                                       $$->timezone = $5;
                                        $$->typmods = list_make1(makeIntConst($3));
                                        $$->location = @1;
                                }
@@ -7211,10 +7207,6 @@ ConstDatetime:
                                                $$ = SystemTypeName("timestamptz");
                                        else
                                                $$ = SystemTypeName("timestamp");
-                                       /* XXX the timezone field seems to be unused
-                                        * - thomas 2001-09-06
-                                        */
-                                       $$->timezone = $2;
                                        $$->location = @1;
                                }
                        | TIME '(' Iconst ')' opt_timezone

diff --git a/src/include/nodes/parsenodes.h b/src/include/nodes/parsenodes.h
index 4b3a6328100328260d7d9ada471648e0057cc68f..f786f1878893df5818f2fd938786926cebef7c7e 100644 (file)
--- a/src/include/nodes/parsenodes.h
+++ b/src/include/nodes/parsenodes.h
@@ -165,7 +165,6 @@ typedef struct TypeName
        NodeTag         type;
        List       *names;                      /* qualified name (list of Value strings) */
        Oid                     typeid;                 /* type identified by OID */
-       bool            timezone;               /* timezone specified? */
        bool            setof;                  /* is a set? */
        bool            pct_type;               /* %TYPE specified? */
        List       *typmods;            /* type modifier expression(s) */