Fix amcheck's handling of half-dead B-tree pages
authorHeikki Linnakangas <heikki.linnakangas@iki.fi>
Tue, 2 Dec 2025 19:11:15 +0000 (21:11 +0200)
committerHeikki Linnakangas <heikki.linnakangas@iki.fi>
Tue, 2 Dec 2025 19:11:15 +0000 (21:11 +0200)
commitcbe04e5d729f292bcf9b06f5d774884b4511b18a
tree888b5b9ddcd3a2277ee7855cd335d73b8f773c52
parentc085aab2781989f487364fab2978d9ee791559a4
Fix amcheck's handling of half-dead B-tree pages

amcheck incorrectly reported the following error if there were any
half-dead pages in the index:

ERROR:  mismatch between parent key and child high key in index
"amchecktest_id_idx"

It's expected that a half-dead page does not have a downlink in the
parent level, so skip the test.

Reported-by: Konstantin Knizhnik <knizhnik@garret.ru>
Reviewed-by: Peter Geoghegan <pg@bowt.ie>
Reviewed-by: Mihail Nikalayeu <mihailnikalayeu@gmail.com>
Discussion: https://www.postgresql.org/message-id/33e39552-6a2a-46f3-8b34-3f9f8004451f@garret.ru
Backpatch-through: 14
contrib/amcheck/verify_nbtree.c
src/test/modules/nbtree/expected/nbtree_half_dead_pages.out
src/test/modules/nbtree/sql/nbtree_half_dead_pages.sql