Avoid premature de-doubling of quote marks in ECPG strings.
authorTom Lane <tgl@sss.pgh.pa.us>
Thu, 22 Oct 2020 21:34:32 +0000 (17:34 -0400)
committerTom Lane <tgl@sss.pgh.pa.us>
Thu, 22 Oct 2020 22:29:46 +0000 (18:29 -0400)
commit3dfb1942d9b8748b93094a430289e2f7f3b3ae0d
treefc5741979ce8e129518f2da8d0bfdd8948444fdf
parent8bb0c9770e80fa79f15b27af8f3c3f2833225aa3
Avoid premature de-doubling of quote marks in ECPG strings.

If you write the literal 'abc''def' in an EXEC SQL command, that will
come out the other end as 'abc'def', triggering a syntax error in the
backend.  Likewise, "abc""def" is reduced to "abc"def" which is wrong
syntax for a quoted identifier.

The cause is that the lexer thinks it should emit just one quote
mark, whereas what it really should do is keep the string as-is.

Add some docs and test cases, too.

Although this seems clearly a bug, I fear users wouldn't appreciate
changing it in minor releases.  Some may well be working around it
by applying an extra doubling of affected quotes, as for example
sql/dyntest.pgc has been doing.

Per investigation of a report from 1250kv, although this isn't
exactly what he/she was on about.

Discussion: https://postgr.es/m/673825.1603223178@sss.pgh.pa.us
doc/src/sgml/ecpg.sgml
src/interfaces/ecpg/preproc/pgc.l
src/interfaces/ecpg/test/expected/preproc-strings.c
src/interfaces/ecpg/test/expected/preproc-strings.stderr
src/interfaces/ecpg/test/expected/preproc-strings.stdout
src/interfaces/ecpg/test/preproc/strings.pgc
src/interfaces/ecpg/test/sql/dyntest.pgc