Correct some code in pg_restore when reading the header of a tar archive:
authorNeil Conway <neilc@samurai.com>
Wed, 22 Jun 2005 02:12:19 +0000 (02:12 +0000)
committerNeil Conway <neilc@samurai.com>
Wed, 22 Jun 2005 02:12:19 +0000 (02:12 +0000)
commit0592a1ebc1f5aa2c91025d1cc631e9c6cccff245
tree9c0f9d56a0c91a1bcc8e7eabe00e2f9bfb5d907a
parenta6f0dee7757aa843eb021c051fb2e85b03efc05e
Correct some code in pg_restore when reading the header of a tar archive:

(1) The code doesn't initialize `sum', so the initial "does the checksum
    match?" test is wrong.

(2) The loop that is intended to check for a "null block" just checks
    the first byte of the tar block 512 times, rather than each of the
    512 bytes one time (!), which I'm guessing was the intent.

It was only through sheer luck that this worked in the first place.

Per Coverity static analysis performed by EnterpriseDB.
src/bin/pg_dump/pg_backup_tar.c