projects / users / c2main / postgres.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: 026762d) | patch
Fix off_t overflow in pg_basebackup on Windows.
authorThomas Munro <tmunro@postgresql.org>
Thu, 9 Jan 2025 00:17:36 +0000 (13:17 +1300)
committerThomas Munro <tmunro@postgresql.org>
Thu, 9 Jan 2025 03:04:23 +0000 (16:04 +1300)
commit970b97eeb8f036e534abe183fd41604671f7674d
treedc1d6c84de613d6a3c147925198195634c98da8ctree
parent026762dae39d6efcbfa99a18a15fdfeecbd5b9cccommit | diff
Fix off_t overflow in pg_basebackup on Windows.

walmethods.c used off_t to navigate around a pg_wal.tar file that could
exceed 2GB, which doesn't work on Windows and would fail with misleading
errors.  Use pgoff_t instead.

Back-patch to all supported branches.

Author: Davinder Singh <davinder.singh@enterprisedb.com>
Reported-by: Jakub Wartak <jakub.wartak@enterprisedb.com>
Discussion: https://postgr.es/m/CAKZiRmyM4YnokK6Oenw5JKwAQ3rhP0YTz2T-tiw5dAQjGRXE3Q%40mail.gmail.com
src/bin/pg_basebackup/receivelog.c diff | blob | blame | history
src/bin/pg_basebackup/walmethods.c diff | blob | blame | history
src/bin/pg_basebackup/walmethods.h diff | blob | blame | history
Cedric's Stuff