Fix snapshot handling bug in recent BRIN fix master
authorÁlvaro Herrera <alvherre@kurilemu.de>
Tue, 4 Nov 2025 19:31:43 +0000 (20:31 +0100)
committerÁlvaro Herrera <alvherre@kurilemu.de>
Tue, 4 Nov 2025 19:31:43 +0000 (20:31 +0100)
commit0a3d27bfe0fb229253aa95feccd0360530b7edd8
treed84a079639191e7824f2e812a831c1e008e28822
parent1213cb475391640508d2495b2b560329897d152c
Fix snapshot handling bug in recent BRIN fix

Commit a95e3d84c0e0 added ActiveSnapshot push+pop when processing
work-items (BRIN autosummarization), but forgot to handle the case of
a transaction failing during the run, which drops the snapshot untimely.
Fix by making the pop conditional on an element being actually there.

Author: Álvaro Herrera <alvherre@kurilemu.de>
Backpatch-through: 13
Discussion: https://postgr.es/m/202511041648.nofajnuddmwk@alvherre.pgsql
src/backend/postmaster/autovacuum.c