From a3a714108b46fc5169f384abaa547cec44b7e070 Mon Sep 17 00:00:00 2001 From: Tom Lane Date: Mon, 22 Oct 2007 17:29:35 +0000 Subject: [PATCH] Be careful to get share lock on each page before computing its free space. ITAGAKI Takahiro --- contrib/pgstattuple/pgstattuple.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/contrib/pgstattuple/pgstattuple.c b/contrib/pgstattuple/pgstattuple.c index 83546d57c3..176f517c52 100644 --- a/contrib/pgstattuple/pgstattuple.c +++ b/contrib/pgstattuple/pgstattuple.c @@ -291,8 +291,7 @@ pgstat_heap(Relation rel, FunctionCallInfo fcinfo) buffer = ReadBuffer(rel, block); LockBuffer(buffer, BUFFER_LOCK_SHARE); stat.free_space += PageGetHeapFreeSpace((Page) BufferGetPage(buffer)); - LockBuffer(buffer, BUFFER_LOCK_UNLOCK); - ReleaseBuffer(buffer); + UnlockReleaseBuffer(buffer); block++; } } @@ -301,8 +300,9 @@ pgstat_heap(Relation rel, FunctionCallInfo fcinfo) while (block < nblocks) { buffer = ReadBuffer(rel, block); + LockBuffer(buffer, BUFFER_LOCK_SHARE); stat.free_space += PageGetHeapFreeSpace((Page) BufferGetPage(buffer)); - ReleaseBuffer(buffer); + UnlockReleaseBuffer(buffer); block++; } -- 2.39.5