From 72ae8922772794abb53c553f169d11b01ffdc9c7 Mon Sep 17 00:00:00 2001
From: Tom Lane <tgl@sss.pgh.pa.us>
Date: Sat, 18 Mar 2000 18:57:16 +0000
Subject: [PATCH] Clean up minor compiler warnings.

---
 convert.c |  7 +++----
 misc.c    | 28 +++++++++++-----------------
 misc.h    |  4 ++--
 options.c |  1 -
 pgtypes.c |  5 +++--
 results.c |  2 +-
 6 files changed, 20 insertions(+), 27 deletions(-)

diff --git a/convert.c b/convert.c
index 4cfe8d4..cef75b2 100644
--- a/convert.c
+++ b/convert.c
@@ -1372,10 +1372,9 @@ int
 convert_lo(StatementClass *stmt, void *value, Int2 fCType, PTR rgbValue, 
 		   SDWORD cbValueMax, SDWORD *pcbValue)
 {
-Oid oid;
-int retval, result, left = -1;
-int bind_row = stmt->bind_row;
-BindInfoClass *bindInfo = NULL;
+	Oid oid;
+	int retval, result, left = -1;
+	BindInfoClass *bindInfo = NULL;
 
 
 /*	If using SQLGetData, then current_col will be set */
diff --git a/misc.c b/misc.c
index 7c0a18f..2833a35 100644
--- a/misc.c
+++ b/misc.c
@@ -13,7 +13,7 @@
  */
 
 #include <stdio.h>
-#include <varargs.h>
+#include <stdarg.h>
 #include <string.h>
 
 #include "psqlodbc.h"
@@ -57,17 +57,14 @@ generate_filename(char* dirname,char* prefix,char* filename)
 #ifdef MY_LOG
 
 void
-mylog(va_alist)
-va_dcl
+mylog(char * fmt, ...)
 {
-char *fmt;
-va_list args;
-char filebuf[80];
+	va_list args;
+	char filebuf[80];
 	FILE* LOGFP = globals.mylogFP;
 
 	if ( globals.debug) {
-		va_start(args);
-		fmt = va_arg(args, char *);
+		va_start(args, fmt);
 
 		if (! LOGFP) {
 			generate_filename(MYLOGDIR,MYLOGFILE,filebuf);
@@ -91,18 +88,15 @@ char filebuf[80];
 
 #ifdef Q_LOG
 
-void qlog(va_alist)
-va_dcl
+void
+qlog(char * fmt, ...)
 {
-char *fmt;
-va_list args;
-char filebuf[80];
-FILE* LOGFP = globals.qlogFP;
+	va_list args;
+	char filebuf[80];
+	FILE* LOGFP = globals.qlogFP;
 
 	if ( globals.commlog) {
-		va_start(args);
-		fmt = va_arg(args, char *);
-
+		va_start(args, fmt);
 
 		if (! LOGFP) {
 			generate_filename(QLOGDIR,QLOGFILE,filebuf);
diff --git a/misc.h b/misc.h
index 10cb511..0cbe928 100644
--- a/misc.h
+++ b/misc.h
@@ -45,7 +45,7 @@
   #else
     #define MYLOGDIR	"c:"
   #endif
-  void mylog();	/* prototype */
+  extern void mylog(char * fmt, ...);
 #else
   #ifndef WIN32
     #define mylog(args...)	/* GNU convention for variable arguments */
@@ -61,7 +61,7 @@
   #else
     #define QLOGDIR		"c:"
   #endif
-  void qlog();	/* prototype */
+  extern void qlog(char * fmt, ...);
 #else
   #ifndef WIN32
     #define qlog(args...)	/* GNU convention for variable arguments */
diff --git a/options.c b/options.c
index ed34a1c..589a9de 100644
--- a/options.c
+++ b/options.c
@@ -474,7 +474,6 @@ RETCODE SQL_API SQLSetStmtOption(
 {
 static char *func="SQLSetStmtOption";
 StatementClass *stmt = (StatementClass *) hstmt;
-char changed = FALSE;
 
 	mylog("%s: entering...\n", func);
 
diff --git a/pgtypes.c b/pgtypes.c
index 3ee5e75..2fedd8f 100644
--- a/pgtypes.c
+++ b/pgtypes.c
@@ -177,6 +177,7 @@ Int4 pgType;
 		break;
 
 	default:
+	  	pgType = 0;	/* ??? */
 		break;
 	}
 
@@ -310,7 +311,7 @@ char *pgtype_to_name(StatementClass *stmt, Int4 type)
 	}    
 }
 
-Int2
+static Int2
 getNumericScale(StatementClass *stmt, Int4 type, int col)
 {
 Int4 atttypmod;
@@ -342,7 +343,7 @@ mylog("getNumericScale: type=%d, col=%d, unknown = %d\n", type,col);
 			PG_NUMERIC_MAX_SCALE);
 }
 
-Int4
+static Int4
 getNumericPrecision(StatementClass *stmt, Int4 type, int col)
 {
 Int4 atttypmod;
diff --git a/results.c b/results.c
index a670329..fe08167 100644
--- a/results.c
+++ b/results.c
@@ -608,7 +608,7 @@ QResultClass *res;
 StatementClass *stmt = (StatementClass *) hstmt;
 int num_cols, num_rows;
 Int4 field_type;
-void *value;
+void *value = NULL;
 int result;
 char get_bookmark = FALSE;
 
-- 
2.39.5