From 6b14312bb4565daeffd0b0778b2ca9e2cacf8ad3 Mon Sep 17 00:00:00 2001 From: Tom Lane Date: Sun, 30 Dec 2001 23:09:42 +0000 Subject: [PATCH] Make sure that all routines are called with unsigned char values; it's not portable to call them with signed chars. I recall doing this for the last release, but a few more uncasted calls have snuck in. --- connection.c | 2 +- convert.c | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/connection.c b/connection.c index e39501f..e057d7b 100644 --- a/connection.c +++ b/connection.c @@ -1092,7 +1092,7 @@ CC_send_query(ConnectionClass *self, char *query, QueryInfo *qi) ReadyToReturn = FALSE; empty_reqs = 0; - for (wq = query; isspace(*wq); wq++) + for (wq = query; isspace((unsigned char) *wq); wq++) ; if (*wq == '\0') empty_reqs = 1; diff --git a/convert.c b/convert.c index 57bf6b7..0b609a0 100644 --- a/convert.c +++ b/convert.c @@ -193,7 +193,7 @@ timestamp2stime(const char *str, SIMPLE_TIME *st, BOOL *bZone, int *zone) } for (i = 1; i < 10; i++) { - if (!isdigit(rest[i])) + if (!isdigit((unsigned char) rest[i])) break; } for (; i < 10; i++) @@ -1351,7 +1351,7 @@ copy_statement_with_parameters(StatementClass *stmt) while (isspace((unsigned char) old_statement[++opos])); } if (strnicmp(&old_statement[opos], "call", lit_call_len) || - !isspace(old_statement[opos + lit_call_len])) + !isspace((unsigned char) old_statement[opos + lit_call_len])) { opos--; continue; @@ -1407,7 +1407,7 @@ copy_statement_with_parameters(StatementClass *stmt) in_dquote = TRUE; else { - if (isspace(oldchar)) + if (isspace((unsigned char) oldchar)) { if (!prev_token_end) { -- 2.39.5