No, really properly check for the old bucarodo_sequences table.

The query returns true if the new table is present, not if the old one
is present.

diff --git a/bucardo.schema b/bucardo.schema
index 7ad5809c703fec92a0e5087d70f4419251c6e63a..b329c72266e8a877a22a73398f1535ce0eda42c9 100644 (file)
--- a/bucardo.schema
+++ b/bucardo.schema
@@ -1893,7 +1893,7 @@ SELECT 'Fixme'::TEXT;
                       .q{ AND attrelid = (SELECT c.oid FROM pg_class c, pg_namespace n }
                       .q{ WHERE n.oid = c.relnamespace AND n.nspname = 'bucardo' }
                       .q{ AND c.relname = 'bucardo_sequences')};
-                if ($dbh->selectall_arrayref($SQL)->[0][0]) {
+                if ($dbh->selectall_arrayref($SQL)->[0][0] < 1) {
                     warn "Dropping older version of bucardo_sequences, then recreating empty\n";
                     $dbh->do('DROP TABLE bucardo.bucardo_sequences');
                     $count = 0;