Improve moderation messages somewhat
authorMagnus Hagander <magnus@hagander.net>
Fri, 18 Sep 2020 09:13:36 +0000 (11:13 +0200)
committerMagnus Hagander <magnus@hagander.net>
Fri, 18 Sep 2020 09:13:36 +0000 (11:13 +0200)
Change the subject to use the title of the object instead of the id, and
include a link to the moderation page. There's surely more to be done,
but this is a decent start.

pgweb/account/views.py
pgweb/core/views.py

index fb3b3ba1877dc7a06beb7c0a598d4ac0801df430..ec98d0ec72470243194e5be5bb11a73759f6556f 100644 (file)
@@ -312,12 +312,13 @@ def _submitted_item_submit(request, objtype, model, obj):
 
                 send_simple_mail(settings.NOTIFICATION_FROM,
                                  settings.NOTIFICATION_EMAIL,
-                                 "{} {} submitted".format(obj._meta.verbose_name.capitalize(), obj.id),
-                                 "{} {} with title '{}' submitted for moderation by {}".format(
+                                 "{} '{}' submitted for moderation".format(obj._meta.verbose_name.capitalize(), obj.title),
+                                 "{} {} with title '{}' submitted for moderation by {}\n\nModerate at: {}\n".format(
                                      obj._meta.verbose_name.capitalize(),
                                      obj.id,
                                      obj.title,
-                                     request.user.username
+                                     request.user.username,
+                                     '{}/admin/_moderate/{}/{}/'.format(settings.SITE_ROOT, obj._meta.model_name, obj.pk),
                                  ),
                                  )
                 return HttpResponseRedirect("/account/edit/{}/".format(objtype))
@@ -348,7 +349,7 @@ def _submitted_item_withdraw(request, objtype, model, obj):
     send_simple_mail(
         settings.NOTIFICATION_FROM,
         settings.NOTIFICATION_EMAIL,
-        "{} {} withdrawn from moderation".format(model._meta.verbose_name.capitalize(), obj.id),
+        "{} '{}' withdrawn from moderation".format(model._meta.verbose_name.capitalize(), obj.title),
         "{} {} with title {} withdrawn from moderation by {}".format(
             model._meta.verbose_name.capitalize(),
             obj.id,
index 78bb4959d7bddff708d26987b7d6daa4f850aa33..b5b93151ff0ea0e01616470cb0d81ab30b30e474 100644 (file)
@@ -378,7 +378,7 @@ def _send_moderation_message(request, obj, message, notice, what):
 
         send_simple_mail(settings.NOTIFICATION_FROM,
                          settings.NOTIFICATION_EMAIL,
-                         "{} {} by {}".format(obj._meta.verbose_name.capitalize(), what, modname),
+                         "{} '{}' {} by {}".format(obj._meta.verbose_name.capitalize(), obj.title, what, modname),
                          admmsg)