Remove Assert(BgWriterShmem != NULL), which is rather pointless since

we'd dump core anyway immediately afterward if it were null; and it
seems to confuse some versions of icc into generating bad code.
Per report from Sergey Koposov.  Patched in HEAD only, for the moment,
since this is only likely to affect developers.

diff --git a/src/backend/postmaster/bgwriter.c b/src/backend/postmaster/bgwriter.c
index d8ecd8569c72ffd13b5613b970ea2e9a8dbc2bc3..8314da84a5f69ca604ca9c42ff32803c849c80a4 100644 (file)
--- a/src/backend/postmaster/bgwriter.c
+++ b/src/backend/postmaster/bgwriter.c
@@ -189,7 +189,6 @@ BackgroundWriterMain(void)
        sigjmp_buf      local_sigjmp_buf;
        MemoryContext bgwriter_context;
 
-       Assert(BgWriterShmem != NULL);
        BgWriterShmem->bgwriter_pid = MyProcPid;
        am_bg_writer = true;
 
@@ -987,7 +986,6 @@ ForwardFsyncRequest(RelFileNode rnode, BlockNumber segno)
 
        if (!IsUnderPostmaster)
                return false;                   /* probably shouldn't even get here */
-       Assert(BgWriterShmem != NULL);
 
        LWLockAcquire(BgWriterCommLock, LW_EXCLUSIVE);
        if (BgWriterShmem->bgwriter_pid == 0 ||