minor cleanups
authorAndres Freund <andres@anarazel.de>
Tue, 28 Jan 2014 20:15:34 +0000 (21:15 +0100)
committerAndres Freund <andres@anarazel.de>
Tue, 28 Jan 2014 20:17:33 +0000 (21:17 +0100)
src/backend/replication/slotfuncs.c

index e89903ec62cf7664e3d94266223e03dccc332b49..cc4c49eba1ae6b3da5ece678823d60acb5b71e9d 100644 (file)
@@ -8,7 +8,7 @@
  * Copyright (c) 2012-2013, PostgreSQL Global Development Group
  *
  * IDENTIFICATION
- *       src/backend/replication/logicalfuncs.c
+ *       src/backend/replication/slotfuncs.c
  *
  */
 
 
 #include "access/htup_details.h"
 
-#include "nodes/makefuncs.h"
-
 #include "utils/builtins.h"
 
 #include "replication/slot.h"
 
-#include "storage/fd.h"
-
 Datum          create_physical_replication_slot(PG_FUNCTION_ARGS);
 Datum          drop_replication_slot(PG_FUNCTION_ARGS);
 
@@ -122,7 +118,11 @@ pg_get_replication_slots(PG_FUNCTION_ARGS)
        if (get_call_result_type(fcinfo, NULL, &tupdesc) != TYPEFUNC_COMPOSITE)
                elog(ERROR, "return type must be a row type");
 
-       /* FIXME: what permissions do we require? */
+       /*
+        * We don't require any special permission to see this function's data
+        * because nothing should be sensitive. The most critical being the slot
+        * name, which shouldn't contain anything particularly sensitive.
+        */
 
        per_query_ctx = rsinfo->econtext->ecxt_per_query_memory;
        oldcontext = MemoryContextSwitchTo(per_query_ctx);