Revert moving the start file to the debug dir.

Was moved in 56ea2b2b4b0ec63383a32e8c886439a451b88929. But this turned out to
confuse things, such that tests were unable to shut down Bucardo, because the
server and the client had a different idea where the file belongs. This is
most likely the reason I was seeing stop failures as reported in GitHub
Issue #11.

Now that I understand that its location can be set via `bucardo set
reason_file`, I am just documenting that.

diff --git a/bucardo b/bucardo
index b7fad1e0c8b06153c4cd8b2d68b9638122f4d750..a298192962c2e914d21f4890c6a6433aa6527ea3 100755 (executable)
--- a/bucardo
+++ b/bucardo
@@ -254,9 +254,7 @@ $dbh->commit();
 ## Set some global variables based on information from the bucardo_config table
 
 ## The reason file records startup and shutdown messages
-my $REASONFILE = "$bcargs->{debugdir}/" . do {
-    get_config('reason_file') or die "Invalid reason_file!\n"
-};
+my $REASONFILE = get_config('reason_file') or die "Invalid reason_file!\n";
 (my $REASONFILE_LOG = $REASONFILE) =~ s{(?:[.][^.]+)?$}{.log};
 
 ## The directory Bucardo.pm writes PID and other information to
@@ -9322,10 +9320,9 @@ to make sure changes get propagated to all databases.
 Starts Bucardo. Fails if the MCP process is running (determined if its PID file is present).
 Otherwise, starts cleanly by first issuing the equivalent of a stop to ask any existing Bucardo
 processes to exit, and then starting a new Bucardo MCP process. A short reason and name should
-be provided - these are written to the C<reason_file> file (F<bucardo.restart.reason.txt> by
-default) in the C<debudir> and sent in the email sent when Bucardo has been started up. It is
-also appended to the reason log, which has the same name as the the C<reason_file> but ends in
-F<.log>.
+be provided - these are written to the C<reason_file> file (F<./bucardo.restart.reason.txt> by
+default) and sent in the email sent when Bucardo has been started up. It is also appended to
+the reason log, which has the same name as the the C<reason_file> but ends in F<.log>.
 
 =item B<stop>
 
@@ -9337,9 +9334,9 @@ will not look for the stop file until they have finished their current run. Typi
 you should scan the list of processes after running this program to make sure that all Bucardo
 processes have stopped. One should also provide a reason for issuing the stop - usually
 this is a short explanation and your name. This is written to the C<reason_file> file
-(F<bucardo.restart.reason.txt> by default) in the C<debugdir> and is also used by Bucardo when
-it exits and sends out mail about its death. It is also appended to the reason log, which has
-the same name as the the C<reason_file> but ends in F<.log>.
+(F<./bucardo.restart.reason.txt> by default) and is also used by Bucardo when it exits and
+sends out mail about its death. It is also appended to the reason log, which has the same name
+as the the C<reason_file> but ends in F<.log>.
 
 =item B<restart>