Reset relhassubclass upon attaching table as a partition
authorAlvaro Herrera <alvherre@alvh.no-ip.org>
Wed, 24 Jul 2024 10:38:18 +0000 (12:38 +0200)
committerAlvaro Herrera <alvherre@alvh.no-ip.org>
Wed, 24 Jul 2024 10:38:18 +0000 (12:38 +0200)
commited743097555ddf8f3ffd7662a608e6765c6820cf
treeda8d6a6eee04223d8c8dfbcc92a761c3e1f05f55
parent6c1b71bc6abee45bd88334a343ae62f8fbeb327d
Reset relhassubclass upon attaching table as a partition

We don't allow inheritance parents as partitions, and have checks to
prevent this; but if a table _was_ in the past an inheritance parents
and all their children are removed, the pg_class.relhassubclass flag
may remain set, which confuses the partition pruning code (most
obviously, it results in an assertion failure; in production builds it
may be worse.)

Fix by resetting relhassubclass on attach.

Backpatch to all supported versions.

Reported-by: Alexander Lakhin <exclusion@gmail.com>
Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us>
Discussion: https://postgr.es/m/18550-d5e047e9a897a889@postgresql.org
src/backend/catalog/heap.c
src/test/regress/expected/alter_table.out
src/test/regress/sql/alter_table.sql