Remove over-eager assertion in ExtendBufferedRelTo()
authorAndres Freund <andres@anarazel.de>
Sun, 21 May 2023 16:48:37 +0000 (09:48 -0700)
committerAndres Freund <andres@anarazel.de>
Sun, 21 May 2023 16:53:49 +0000 (09:53 -0700)
commiteabb22525efc40ce0d83580584094a0248ac0682
tree9794f20a89b2c0b0d93d51b236c7a0b8f1beeaff
parentbc971f4025c378ce500d86597c34b0ef996d4d8c
Remove over-eager assertion in ExtendBufferedRelTo()

The assertion checked that the size of the relation is not "too large" - but
the code is explicitly dealing with the possibility of another backend
extending the relation concurrently. In that case the new relation size could
be bigger than what the current backend needs, wrongly triggering an assertion
failure.

Unfortunately it is hard to write a reliable and affordable regression tests
for this, as a lot of concurrency is needed to encounter the bug.

Introduced in 31966b151e6a.

Reported-by: Melanie Plageman <melanieplageman@gmail.com>
src/backend/storage/buffer/bufmgr.c