Avoid repeating loads of frozen ID values.
authorNoah Misch <noah@leadboat.com>
Mon, 29 Apr 2024 17:25:33 +0000 (10:25 -0700)
committerNoah Misch <noah@leadboat.com>
Mon, 29 Apr 2024 17:25:33 +0000 (10:25 -0700)
commitdd0183469bb779247c96e86c2272dca7ff4ec9e7
tree1e2998dec368e7476dde36894e2b7f4356308f12
parentf65ab862e3b8d96c6886641155d9447bc73b5126
Avoid repeating loads of frozen ID values.

Repeating loads of inplace-updated fields tends to cause bugs like the
one from the previous commit.  While there's no bug to fix in these code
sites, adopt the load-once style.  This improves the chance of future
copy/paste finding the safe style.

Discussion: https://postgr.es/m/20240423003956.e7.nmisch@google.com
src/backend/access/heap/heapam.c
src/backend/commands/cluster.c
src/backend/commands/vacuum.c
src/backend/postmaster/autovacuum.c